Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: src/arm64/interface-descriptors-arm64.cc

Issue 1237813002: Switch CallConstructStub to take new.target in register. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments about ARM and MIPS. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/interface-descriptors.h" 9 #include "src/interface-descriptors.h"
10 10
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 Register registers[] = {x1, x3, x2}; 185 Register registers[] = {x1, x3, x2};
186 data->InitializePlatformSpecific(arraysize(registers), registers); 186 data->InitializePlatformSpecific(arraysize(registers), registers);
187 } 187 }
188 188
189 189
190 void CallConstructDescriptor::InitializePlatformSpecific( 190 void CallConstructDescriptor::InitializePlatformSpecific(
191 CallInterfaceDescriptorData* data) { 191 CallInterfaceDescriptorData* data) {
192 // x0 : number of arguments 192 // x0 : number of arguments
193 // x1 : the function to call 193 // x1 : the function to call
194 // x2 : feedback vector 194 // x2 : feedback vector
195 // x3 : slot in feedback vector (smi) (if r2 is not the megamorphic symbol) 195 // x3 : slot in feedback vector (Smi, for RecordCallTarget)
196 // x4 : original constructor (for IsSuperConstructorCall)
196 // TODO(turbofan): So far we don't gather type feedback and hence skip the 197 // TODO(turbofan): So far we don't gather type feedback and hence skip the
197 // slot parameter, but ArrayConstructStub needs the vector to be undefined. 198 // slot parameter, but ArrayConstructStub needs the vector to be undefined.
198 Register registers[] = {x0, x1, x2}; 199 Register registers[] = {x0, x1, x4, x2};
199 data->InitializePlatformSpecific(arraysize(registers), registers); 200 data->InitializePlatformSpecific(arraysize(registers), registers);
200 } 201 }
201 202
202 203
203 void RegExpConstructResultDescriptor::InitializePlatformSpecific( 204 void RegExpConstructResultDescriptor::InitializePlatformSpecific(
204 CallInterfaceDescriptorData* data) { 205 CallInterfaceDescriptorData* data) {
205 // x2: length 206 // x2: length
206 // x1: index (of last match) 207 // x1: index (of last match)
207 // x0: string 208 // x0: string
208 Register registers[] = {x2, x1, x0}; 209 Register registers[] = {x2, x1, x0};
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 x1, // math rounding function 417 x1, // math rounding function
417 x3, // vector slot id 418 x3, // vector slot id
418 x4, // type vector 419 x4, // type vector
419 }; 420 };
420 data->InitializePlatformSpecific(arraysize(registers), registers); 421 data->InitializePlatformSpecific(arraysize(registers), registers);
421 } 422 }
422 } // namespace internal 423 } // namespace internal
423 } // namespace v8 424 } // namespace v8
424 425
425 #endif // V8_TARGET_ARCH_ARM64 426 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698