Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: src/arm/interface-descriptors-arm.cc

Issue 1237813002: Switch CallConstructStub to take new.target in register. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments about ARM and MIPS. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/interface-descriptors.h" 9 #include "src/interface-descriptors.h"
10 10
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 Register registers[] = {r1, r3, r2}; 162 Register registers[] = {r1, r3, r2};
163 data->InitializePlatformSpecific(arraysize(registers), registers); 163 data->InitializePlatformSpecific(arraysize(registers), registers);
164 } 164 }
165 165
166 166
167 void CallConstructDescriptor::InitializePlatformSpecific( 167 void CallConstructDescriptor::InitializePlatformSpecific(
168 CallInterfaceDescriptorData* data) { 168 CallInterfaceDescriptorData* data) {
169 // r0 : number of arguments 169 // r0 : number of arguments
170 // r1 : the function to call 170 // r1 : the function to call
171 // r2 : feedback vector 171 // r2 : feedback vector
172 // r3 : (only if r2 is not the megamorphic symbol) slot in feedback 172 // r3 : slot in feedback vector (Smi, for RecordCallTarget)
173 // vector (Smi) 173 // r4 : original constructor (for IsSuperConstructorCall)
174 // TODO(turbofan): So far we don't gather type feedback and hence skip the 174 // TODO(turbofan): So far we don't gather type feedback and hence skip the
175 // slot parameter, but ArrayConstructStub needs the vector to be undefined. 175 // slot parameter, but ArrayConstructStub needs the vector to be undefined.
176 Register registers[] = {r0, r1, r2}; 176 Register registers[] = {r0, r1, r4, r2};
177 data->InitializePlatformSpecific(arraysize(registers), registers); 177 data->InitializePlatformSpecific(arraysize(registers), registers);
178 } 178 }
179 179
180 180
181 void RegExpConstructResultDescriptor::InitializePlatformSpecific( 181 void RegExpConstructResultDescriptor::InitializePlatformSpecific(
182 CallInterfaceDescriptorData* data) { 182 CallInterfaceDescriptorData* data) {
183 Register registers[] = {r2, r1, r0}; 183 Register registers[] = {r2, r1, r0};
184 data->InitializePlatformSpecific(arraysize(registers), registers); 184 data->InitializePlatformSpecific(arraysize(registers), registers);
185 } 185 }
186 186
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 r1, // math rounding function 380 r1, // math rounding function
381 r3, // vector slot id 381 r3, // vector slot id
382 r4, // type vector 382 r4, // type vector
383 }; 383 };
384 data->InitializePlatformSpecific(arraysize(registers), registers); 384 data->InitializePlatformSpecific(arraysize(registers), registers);
385 } 385 }
386 } // namespace internal 386 } // namespace internal
387 } // namespace v8 387 } // namespace v8
388 388
389 #endif // V8_TARGET_ARCH_ARM 389 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698