Issue 12378092: Linux: for use_system_v8=1, use all_dependent_settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12378092: Linux: for use_system_v8=1, use all_dependent_settings (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Linux: for use_system_v8=1, use all_dependent_settings instead of direct_dependent_settings - with V8 headers being included in other headers, the former works much better. This is a configuration that is not used for Google Chrome neither V8 buildbot, and has been tested for its intended use case (Linux distributions). BUG=none Committed: http://code.google.com/p/v8/source/detail?r=13822

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

7 years, 9 months ago (2013-03-05 09:49:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13822 (presubmit successful).

Expand Messages | Collapse Messages