chrome/renderer/resources/extensions/notification_custom_bindings.js - Issue 12378077: Attempting to fix problems in 11571014.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/notification_custom_bindings.js

Issue 12378077: Attempting to fix problems in 11571014. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: oops Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/miscellaneous_bindings.js ('k') | chrome/renderer/resources/extensions/send_request.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/notification_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/notification_custom_bindings.js b/chrome/renderer/resources/extensions/notification_custom_bindings.js

index 0e2cd137aa9cffa0d822ed8139ea22ad2b0794bb..074bbdb00a49bd5cddba0366a44907105b6e3f5f 100644

--- a/chrome/renderer/resources/extensions/notification_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/notification_custom_bindings.js

@@ -111,8 +111,11 @@ function genHandle(failure_function) {

that.definition.parameters);

return;

}

- lastError.set('Unable to download all specified images.');

- failure_function(callback, id);

+ // TODO(kalman): This is probably wrong, failure_function is created in

+ // this context but it should be created in the caller's context. I just

+ // don't know where that is.

+ lastError.run('Unable to download all specified images.',

+ failure_function);

});

};

}