Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 12378075: Provide an option in bench_pictures to count pixel ram. (Closed)

Created:
7 years, 9 months ago by scroggo
Modified:
7 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Provide an option in bench_pictures to count pixel ram. In SkLruImageCache, provide an option to keep all pixels, and document the new behavior. In gm/factory.cpp, set the budget for the Lru image cache to 1, to retain (basically) the old behavior. BUG=https://code.google.com/p/skia/issues/detail?id=1010 Committed: https://code.google.com/p/skia/source/detail?r=7972

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change API to share style with font cache. #

Patch Set 3 : Use the logger rather than debug statements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M gm/factory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/lazy/SkLruImageCache.h View 1 1 chunk +15 lines, -1 line 0 comments Download
M src/lazy/SkLruImageCache.cpp View 1 2 chunks +7 lines, -3 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 2 3 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scroggo
7 years, 9 months ago (2013-03-04 17:20:30 UTC) #1
reed1
I see an API addition, and a mode that emits (lots?) of debugging printfs. Are ...
7 years, 9 months ago (2013-03-04 20:07:27 UTC) #2
scroggo
> I see an API addition, and a mode that emits (lots?) of debugging printfs. ...
7 years, 9 months ago (2013-03-04 20:49:29 UTC) #3
reed1
lgtm
7 years, 9 months ago (2013-03-04 20:55:02 UTC) #4
scroggo
I just realized that it would have been more clear that these aren't debug statements ...
7 years, 9 months ago (2013-03-04 21:16:04 UTC) #5
scroggo
7 years, 9 months ago (2013-03-04 21:35:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r7972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698