Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: src/spaces.cc

Issue 12378071: Fix assert in PagedSpace::SizeOfObject for concurrent sweeping. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/spaces.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/spaces.cc
diff --git a/src/spaces.cc b/src/spaces.cc
index 91f8b81ed8c27be4702ee51b9a14d2dca1f6f8fe..1d6a4ac36e0ed2bb0268977e771b31100f3a1448 100644
--- a/src/spaces.cc
+++ b/src/spaces.cc
@@ -2476,6 +2476,13 @@ bool PagedSpace::ReserveSpace(int size_in_bytes) {
}
+intptr_t PagedSpace::SizeOfObjects() {
+ ASSERT(!IsLazySweepingComplete() || (unswept_free_bytes_ == 0) ||
+ heap()->mark_compact_collector()->IsConcurrentSweepingInProgress());
Michael Starzinger 2013/03/04 15:26:29 Better use the following assertion ... ASSERT(hea
Hannes Payer (out of office) 2013/03/04 15:47:41 Done. I changed the ASSERT as suggested, but now
+ return Size() - unswept_free_bytes_ - (limit() - top());
+}
+
+
// After we have booted, we have created a map which represents free space
// on the heap. If there was already a free list then the elements on it
// were created with the wrong FreeSpaceMap (normally NULL), so we need to
« no previous file with comments | « src/spaces.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698