Fix assert in PagedSpace::SizeOfObject for concurrent sweeping.

Fix assert in PagedSpace::SizeOfObject for concurrent sweeping.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13814

[Michael Starzinger, 2013-03-04 15:26:29]

https://codereview.chromium.org/12378071/diff/1/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/12378071/diff/1/src/spaces.cc#newcode2481
src/spaces.cc:2481:
heap()->mark_compact_collector()->IsConcurrentSweepingInProgress());
Better use the following assertion ...

ASSERT(heap()->IsSweepingComplete() || (unswept_free_bytes_ == 0));

... and move it back to the header so that it can be inlined.

[Michael Starzinger, 2013-03-04 15:39:15]

LGTM. As discussed offline, keeping it in the header is no longer possible, I
see that now. I still think using the Heap::IsSweepingComplete() predicate is
cleaner, but I leave that up to you.

[Hannes Payer (out of office), 2013-03-04 15:47:40]

https://codereview.chromium.org/12378071/diff/1/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/12378071/diff/1/src/spaces.cc#newcode2481
src/spaces.cc:2481:
heap()->mark_compact_collector()->IsConcurrentSweepingInProgress());
On 2013/03/04 15:26:29, Michael Starzinger wrote:
> Better use the following assertion ...
> 
> ASSERT(heap()->IsSweepingComplete() || (unswept_free_bytes_ == 0));
> 
> ... and move it back to the header so that it can be inlined.

Done.

I changed the ASSERT as suggested, but now it is weaker.

[Hannes Payer (out of office), 2013-03-04 15:48:06]

Committed patchset #2 manually as r13814 (presubmit successful).