Make autofill stop depending on InfoBarService

chrome/browser/autofill/autofill_cc_infobar_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_cc_infobar_delegate.h"
 
 #include "base/logging.h"
 #include "chrome/browser/api/infobars/infobar_service.h"
 #include "chrome/browser/autofill/credit_card.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/page_navigator.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 // static
-void AutofillCCInfoBarDelegate::Create(
-    InfoBarService* infobar_service,
-    const CreditCard* credit_card,
-    PersonalDataManager* personal_data,
-    const AutofillMetrics* metric_logger) {
+void AutofillCCInfoBarDelegate::Create(InfoBarService* infobar_service,
+                                       const AutofillMetrics* metric_logger,
+                                       const base::Closure& import_callback) {
   infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
-      new AutofillCCInfoBarDelegate(infobar_service, credit_card, personal_data,
-                                    metric_logger)));
+      new AutofillCCInfoBarDelegate(
+          infobar_service, metric_logger, import_callback)));
+  metric_logger->LogCreditCardInfoBarMetric(AutofillMetrics::INFOBAR_SHOWN);

[Ilya Sherman, 2013/03/06 09:13:24]

Hmm, why did you move this out of the constructor?

[kaiwang, 2013/03/06 18:25:04]

Creating an infobar delegate does not mean showing it. Just try to make it more
accurate.

+}
+
+// static
+scoped_ptr<ConfirmInfoBarDelegate> AutofillCCInfoBarDelegate::CreateForTesting(
+    const AutofillMetrics* metric_logger,
+    const base::Closure& import_callback) {
+  metric_logger->LogCreditCardInfoBarMetric(AutofillMetrics::INFOBAR_SHOWN);
+  return scoped_ptr<ConfirmInfoBarDelegate>(
+      new AutofillCCInfoBarDelegate(NULL, metric_logger, import_callback));
 }
 
 AutofillCCInfoBarDelegate::AutofillCCInfoBarDelegate(
     InfoBarService* infobar_service,
-    const CreditCard* credit_card,
-    PersonalDataManager* personal_data,
-    const AutofillMetrics* metric_logger)
+    const AutofillMetrics* metric_logger,
+    const base::Closure& import_callback)
     : ConfirmInfoBarDelegate(infobar_service),
-      credit_card_(credit_card),
-      personal_data_(personal_data),
       metric_logger_(metric_logger),
-      had_user_interaction_(false) {
-  metric_logger_->LogCreditCardInfoBarMetric(AutofillMetrics::INFOBAR_SHOWN);
-}
+      import_callback_(import_callback),
+      had_user_interaction_(false) {}
 
 AutofillCCInfoBarDelegate::~AutofillCCInfoBarDelegate() {
   if (!had_user_interaction_)
     LogUserAction(AutofillMetrics::INFOBAR_IGNORED);
 }
 
 void AutofillCCInfoBarDelegate::LogUserAction(
     AutofillMetrics::InfoBarMetric user_action) {
   DCHECK(!had_user_interaction_);
 
@@ skipping 25 matching lines @@
 string16 AutofillCCInfoBarDelegate::GetMessageText() const {
   return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_INFOBAR_TEXT);
 }
 
 string16 AutofillCCInfoBarDelegate::GetButtonLabel(InfoBarButton button) const {
   return l10n_util::GetStringUTF16((button == BUTTON_OK) ?
       IDS_AUTOFILL_CC_INFOBAR_ACCEPT : IDS_AUTOFILL_CC_INFOBAR_DENY);
 }
 
 bool AutofillCCInfoBarDelegate::Accept() {
-  personal_data_->SaveImportedCreditCard(*credit_card_);
+  import_callback_.Run();
+  import_callback_.Reset();
   LogUserAction(AutofillMetrics::INFOBAR_ACCEPTED);
   return true;
 }
 
 bool AutofillCCInfoBarDelegate::Cancel() {
   LogUserAction(AutofillMetrics::INFOBAR_DENIED);
   return true;
 }
 
 string16 AutofillCCInfoBarDelegate::GetLinkText() const {
   return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
 }
 
 bool AutofillCCInfoBarDelegate::LinkClicked(WindowOpenDisposition disposition) {
   owner()->GetWebContents()->GetDelegate()->OpenURLFromTab(
       owner()->GetWebContents(),
       content::OpenURLParams(GURL(chrome::kAutofillHelpURL),
                              content::Referrer(),
                              NEW_FOREGROUND_TAB,
                              content::PAGE_TRANSITION_LINK,
                              false));
   return false;
 }