Issue 12378048: [Android] Switch instrumentation tests to the new shard/runner paradigm.

Issue 12378048: [Android] Switch instrumentation tests to the new shard/runner paradigm. (Closed)

Created:
7 years, 9 months ago by craigdh

Modified:
7 years, 9 months ago

Reviewers:
felipeg, frankf

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Switch instrumentation tests to the new shard/runner paradigm. BUG=176325, 168889 TEST=build/android/run_instrumentation_tests.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186266

Patch Set 1 #

Total comments: 10

Patch Set 2 : nits and fix python driven tests #

Patch Set 3 : fix host_driven tests #

Patch Set 4 : explicitly call SetUp and TearDown in host_driven tests. #

Patch Set 5 : fix content_browsertests #

Patch Set 6 : add retries to the end of the queue instead of the beginning #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -522 lines)			Patch
M	build/android/pylib/base/base_test_runner.py	View		4 chunks	+12 lines, -22 lines	0 comments	Download
D	build/android/pylib/base/base_test_sharder.py	View		1 chunk	+0 lines, -160 lines	0 comments	Download
D	build/android/pylib/base/new_base_test_runner.py	View		1 chunk	+0 lines, -198 lines	0 comments	Download
M	build/android/pylib/base/shard.py	View	1 2 3 4 5	6 chunks	+37 lines, -12 lines	0 comments	Download
M	build/android/pylib/base/shard_unittest.py	View		4 chunks	+15 lines, -4 lines	0 comments	Download
M	build/android/pylib/browsertests/dispatch.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/gtest/dispatch.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/android/pylib/gtest/test_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/host_driven/python_test_base.py	View	1 2 3	1 chunk	+7 lines, -3 lines	0 comments	Download
M	build/android/pylib/host_driven/run_python_tests.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/android/pylib/instrumentation/dispatch.py	View	1	3 chunks	+10 lines, -7 lines	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View	1	9 chunks	+56 lines, -71 lines	0 comments	Download
D	build/android/pylib/instrumentation/test_sharder.py	View		1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm w/ nits. Please wait for felipeg. https://codereview.chromium.org/12378048/diff/1/build/android/pylib/instrumentation/dispatch.py File build/android/pylib/instrumentation/dispatch.py (right): https://codereview.chromium.org/12378048/diff/1/build/android/pylib/instrumentation/dispatch.py#newcode83 build/android/pylib/instrumentation/dispatch.py:83: raise Exception('You ...

7 years, 9 months ago (2013-03-01 20:32:07 UTC) #3

craigdh

https://codereview.chromium.org/12378048/diff/1/build/android/pylib/instrumentation/dispatch.py File build/android/pylib/instrumentation/dispatch.py (right): https://codereview.chromium.org/12378048/diff/1/build/android/pylib/instrumentation/dispatch.py#newcode83 build/android/pylib/instrumentation/dispatch.py:83: raise Exception('You have no devices attached and visible!') On ...

7 years, 9 months ago (2013-03-01 21:45:11 UTC) #4

craigdh

Committed patchset #6 manually as r186266 (presubmit successful).

7 years, 9 months ago (2013-03-05 21:54:58 UTC) #5

Message was sent while issue was closed.

forwarder bits LGTM

Expand Messages | Collapse Messages