Move apps_shortcut_manager into src/apps

chrome/browser/extensions/api/extension_action/extension_action_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/lazy_instance.h"
@@ skipping 13 matching lines @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h"
 #include "chrome/common/extensions/api/extension_action/page_action_handler.h"
 #include "chrome/common/extensions/api/extension_action/script_badge_handler.h"
 #include "chrome/common/render_messages.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "extensions/common/error_utils.h"
+#include "ui/gfx/image/image.h"

[Matt Giuca, 2013/03/04 00:10:46]

Why do you add this #include to a bunch of files? I assume it's an include what
you use thing, but it doesn't seem related to this CL.

[benwells, 2013/03/04 01:30:03]

These were included previously from transitive includes, via extension_service
and app_shortcut_manager. Now that extension_service doesn't include
app_shortcut_manager, these files all fail to compile without this include.

So yeah, it is an IWYU thing: this is why IWYU is important, so poor folks like
me don't get inflicted with this kind of pain when making unrelated changes :)

 #include "ui/gfx/image/image_skia.h"
 
 namespace extensions {
 
 namespace {
 
 const char kBrowserActionStorageKey[] = "browser_action";
 const char kPopupUrlStorageKey[] = "poupup_url";
 const char kTitleStorageKey[] = "title";
 const char kIconStorageKey[] = "icon";
@@ skipping 688 matching lines @@
   return true;
 }
 
 bool EnablePageActionsFunction::RunImpl() {
   return SetPageActionEnabled(true);
 }
 
 bool DisablePageActionsFunction::RunImpl() {
   return SetPageActionEnabled(false);
 }