Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: gpu/command_buffer/service/buffer_manager_unittest.cc

Issue 12378034: Use client side arrays for GL_STREAM_DRAW attributes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix copy bug Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/buffer_manager.cc ('k') | gpu/command_buffer/service/context_group.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/buffer_manager_unittest.cc
diff --git a/gpu/command_buffer/service/buffer_manager_unittest.cc b/gpu/command_buffer/service/buffer_manager_unittest.cc
index e782e7f9100983b1614f8dd4e439592f89482112..f3279eebe957168c7c44fd869f79e62cbdeb636f 100644
--- a/gpu/command_buffer/service/buffer_manager_unittest.cc
+++ b/gpu/command_buffer/service/buffer_manager_unittest.cc
@@ -73,6 +73,7 @@ TEST_F(BufferManagerTest, Basic) {
EXPECT_EQ(0, info1->size());
EXPECT_EQ(static_cast<GLenum>(GL_STATIC_DRAW), info1->usage());
EXPECT_FALSE(info1->IsDeleted());
+ EXPECT_FALSE(info1->IsClientSideArray());
EXPECT_EQ(kServiceBuffer1Id, info1->service_id());
GLuint client_id = 0;
EXPECT_TRUE(manager_->GetClientId(info1->service_id(), &client_id));
@@ -298,6 +299,10 @@ TEST_F(BufferManagerTest, UseDeletedBuffer) {
info = NULL;
}
+// TODO(gman): Test buffers get shadowed when they are supposed to
+// TODO(gman): Test they get release if usage changes.
+// TODO(gman): Test is_client_side_array gets set/unset
+
} // namespace gles2
} // namespace gpu
« no previous file with comments | « gpu/command_buffer/service/buffer_manager.cc ('k') | gpu/command_buffer/service/context_group.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698