Use client side arrays for GL_STREAM_DRAW attributes

gpu/command_buffer/service/buffer_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/buffer_manager.h"
 #include "gpu/command_buffer/service/mocks.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gl/gl_mock.h"
 
 using ::testing::StrictMock;
@@ skipping 55 matching lines @@
   const GLuint kClientBuffer2Id = 2;
   // Check we can create buffer.
   manager_->CreateBuffer(kClientBuffer1Id, kServiceBuffer1Id);
   // Check buffer got created.
   Buffer* info1 = manager_->GetBuffer(kClientBuffer1Id);
   ASSERT_TRUE(info1 != NULL);
   EXPECT_EQ(0u, GetTarget(info1));
   EXPECT_EQ(0, info1->size());
   EXPECT_EQ(static_cast<GLenum>(GL_STATIC_DRAW), info1->usage());
   EXPECT_FALSE(info1->IsDeleted());
+  EXPECT_FALSE(info1->IsClientSideArray());
   EXPECT_EQ(kServiceBuffer1Id, info1->service_id());
   GLuint client_id = 0;
   EXPECT_TRUE(manager_->GetClientId(info1->service_id(), &client_id));
   EXPECT_EQ(kClientBuffer1Id, client_id);
   manager_->SetTarget(info1, GL_ELEMENT_ARRAY_BUFFER);
   EXPECT_EQ(static_cast<GLenum>(GL_ELEMENT_ARRAY_BUFFER), GetTarget(info1));
   // Check we and set its size.
   manager_->SetInfo(info1, kBuffer1Size, GL_DYNAMIC_DRAW);
   EXPECT_EQ(kBuffer1Size, info1->size());
   EXPECT_EQ(static_cast<GLenum>(GL_DYNAMIC_DRAW), info1->usage());
@@ skipping 205 matching lines @@
   manager_->RemoveBuffer(kClientBufferId);
   // Use it after removing
   manager_->SetInfo(info, sizeof(data), GL_STATIC_DRAW);
   // Check that it gets deleted when the last reference is released.
   EXPECT_CALL(*gl_, DeleteBuffersARB(1, ::testing::Pointee(kServiceBufferId)))
       .Times(1)
       .RetiresOnSaturation();
   info = NULL;
 }
 
+// TODO(gman): Test buffers get shadowed when they are supposed to
+// TODO(gman): Test they get release if usage changes.
+// TODO(gman): Test is_client_side_array gets set/unset
+
 }  // namespace gles2
 }  // namespace gpu