Issue 12378034: Use client side arrays for GL_STREAM_DRAW attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12378034: Use client side arrays for GL_STREAM_DRAW attributes (Closed)

Created:
7 years, 9 months ago by greggman

Modified:
7 years, 9 months ago

Reviewers:

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use client side arrays for GL_STREAM_DRAW attributes Certain GPU/drivers are slow when using constantly changing vertex buffers. They also run out of memory as the pipeline the buffers so while a buffer is in used being drawn to they can't delete it immediately when you upload new data to the buffer. This is an attempt to work around that issue seemlessly by using client side arrays for buffers marked as GL_STREAM_DRAW BUG=178093

Patch Set 1 #

Patch Set 2 : fix bugs #

Patch Set 3 : fix mem access issue on used attributes #

Patch Set 4 : fix copy bug #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+476 lines, -88 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h	View	1	9 chunks	+7 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager.h	View		7 chunks	+19 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager.cc	View	1 2 3	4 chunks	+26 lines, -9 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager_unittest.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/context_group.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/feature_info.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/command_buffer/service/feature_info.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2 3	10 chunks	+74 lines, -64 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_mock.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/vertex_attrib_manager.h	View		4 chunks	+22 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/vertex_attrib_manager.cc	View	1 2 3	3 chunks	+114 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/tests/gl_stream_draw_unittests.cc	View	1	1 chunk	+157 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/tests/gl_test_utils.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/tests/gl_test_utils.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	gpu/gpu.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download