Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3484)

Unified Diff: build/standalone.gypi

Issue 1237803003: Use msvs toolchain from depot_tools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Adding a landmine Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/gyp_v8 ('k') | build/vs_toolchain.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 400694486c5c42af314f2f350abc28bc6e1ffcef..3f54eb3eccc8e3fea51d485a61ea5e7402a2bffe 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -97,6 +97,10 @@
'cfi_blacklist%': '<(base_dir)/tools/cfi/blacklist.txt',
+ # Set to 1 to enable fast builds.
+ # TODO(machenbach): Only configured for windows.
+ 'fastbuild%': 0,
+
# goma settings.
# 1 to use goma.
# If no gomadir is set, it uses the default gomadir.
@@ -155,6 +159,7 @@
'cfi_diag%': '<(cfi_diag)',
'cfi_blacklist%': '<(cfi_blacklist)',
'test_isolation_mode%': '<(test_isolation_mode)',
+ 'fastbuild%': '<(fastbuild)',
# Add a simple extras solely for the purpose of the cctests
'v8_extra_library_files': ['../test/cctest/test-extra.js'],
@@ -206,12 +211,8 @@
['OS=="win" and use_goma==1', {
# goma doesn't support pch yet.
'chromium_win_pch': 0,
- # goma doesn't support PDB yet, so win_z7=1 or fastbuild=1.
- 'conditions': [
- ['win_z7==0 and fastbuild==0', {
- 'fastbuild': 1,
- }],
- ],
+ # goma doesn't support PDB yet.
+ 'fastbuild%': 1,
}],
['((v8_target_arch=="ia32" or v8_target_arch=="x64" or v8_target_arch=="x87") and \
(OS=="linux" or OS=="mac")) or (v8_target_arch=="ppc64" and OS=="linux")', {
@@ -433,6 +434,23 @@
}],
],
}],
+ ['fastbuild!=0', {
+ 'conditions': [
+ ['OS=="win" and fastbuild==1', {
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ # This tells the linker to generate .pdbs, so that
+ # we can get meaningful stack traces.
+ 'GenerateDebugInformation': 'true',
+ },
+ 'VCCLCompilerTool': {
+ # No debug info to be generated by compiler.
+ 'DebugInformationFormat': '0',
+ },
+ },
+ }],
+ ],
+ }], # fastbuild!=0
],
'target_conditions': [
['v8_code == 0', {
« no previous file with comments | « build/gyp_v8 ('k') | build/vs_toolchain.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698