Record InstantExtended pref setting on startup with an UMA histogram.

chrome/browser/ui/search/search.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/search.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 261 matching lines @@
     const TemplateURLRef& instant_url_ref = template_url->instant_url_ref();
     effective_url = CoerceCommandLineURLToTemplateURL(url, instant_url_ref);
   }
 
   return ShouldAssignURLToInstantRendererImpl(
              effective_url,
              IsInstantExtendedAPIEnabled(profile),
              template_url);
 }
 
+void RecordInstantExtendedPrefValue(bool pref_value) {
+  static bool recorded = false;

[sreeram, 2013/03/01 16:42:07]

This bool is static across the whole browser process, not per profile. So, this
histogram will only be recorded for the first profile that creates a window.
That's not what we want, I guess?

[Alexei Svitkine (slow), 2013/03/01 17:57:56]

I agree that's kind of weird. From the bug:

"It's much better to have an
opt-in/opt-out/eligible-for-field-trial-to-assign-status histogram recorded
regularly (either on startup or every so often or upon some user action).  Then
we can easily tell what percent of the population opted out.  Recording a user
action only tell X people opted out this day.  That can zero if no one new is
opting out, but we can still have a huge population that disappeared.  If we
don't happen to look at the user action counts on the day they disappeared then
we'd be entirely oblivious to this negative reaction."

Perhaps we should take this discussion there?

(Note: The above quote is also kind of mixing up the about:flags setting with
this one.)

+  if (!recorded) {
+    UMA_HISTOGRAM_BOOLEAN("InstantExtended.PrefValue", pref_value);
+    recorded = true;
+  }
+}
+
 void EnableInstantExtendedAPIForTesting() {
   CommandLine* cl = CommandLine::ForCurrentProcess();
   cl->AppendSwitch(switches::kEnableInstantExtendedAPI);
 }
 
 void EnableQueryExtractionForTesting() {
 #if defined(OS_IOS)
   CommandLine* cl = CommandLine::ForCurrentProcess();
   cl->AppendSwitch(switches::kEnableQueryExtraction);
 #else
@@ skipping 117 matching lines @@
   GURL::Replacements replacements;
   replacements.SetSchemeStr(search_scheme);
   replacements.SetHostStr(search_host);
   replacements.SetPortStr(search_port);
   replacements.SetPathStr(search_path);
   return instant_url.ReplaceComponents(replacements);
 }
 
 }  // namespace search
 }  // namespace chrome