[Android WebView] Add simple support for remote web debugging

[Android WebView] Add simple support for remote web debugging

This is a non-final way of exposing web debugging for WebView,
but it is extremely useful for anyone who needs to debug its
web content in the new version of WebView.

This patch unconditionally exposes 'webview_devtools_remote_<pid>'
linux abstract socket for remote debugging. The DevTools frontend
is already being bundled with WebView, so this patch doesn't add
any new resources.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185543

[benm (inactive), 2013-02-28 14:54:12]

This is way awesome!

Is the plan to land in this preliminary state, or keep this as a patch we can
apply as and when needed?

https://codereview.chromium.org/12378011/diff/1/android_webview/browser/aw_de...
File android_webview/browser/aw_devtools_delegate.cc (right):

https://codereview.chromium.org/12378011/diff/1/android_webview/browser/aw_de...
android_webview/browser/aw_devtools_delegate.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
2013

https://codereview.chromium.org/12378011/diff/1/android_webview/browser/aw_de...
File android_webview/browser/aw_devtools_delegate.h (right):

https://codereview.chromium.org/12378011/diff/1/android_webview/browser/aw_de...
android_webview/browser/aw_devtools_delegate.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
nit: 2013

[mnaganov (inactive), 2013-02-28 16:33:03]

I'd commit it. The more test exposure we will have, the better. As WebView is
currently under development, having web debugging always enabled and accessed
via non user-friendly ways is fine.

https://codereview.chromium.org/12378011/diff/1/android_webview/browser/aw_de...
File android_webview/browser/aw_devtools_delegate.cc (right):

https://codereview.chromium.org/12378011/diff/1/android_webview/browser/aw_de...
android_webview/browser/aw_devtools_delegate.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2013/02/28 14:54:12, benm wrote:
> 2013

Done.

https://codereview.chromium.org/12378011/diff/1/android_webview/browser/aw_de...
File android_webview/browser/aw_devtools_delegate.h (right):

https://codereview.chromium.org/12378011/diff/1/android_webview/browser/aw_de...
android_webview/browser/aw_devtools_delegate.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2013/02/28 14:54:12, benm wrote:
> nit: 2013

Right. Also, '(c)' is no longer needed.

[benm (inactive), 2013-03-01 13:02:35]

lgtm

https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
File android_webview/browser/aw_devtools_delegate.cc (right):

https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
android_webview/browser/aw_devtools_delegate.cc:36: // The call below destroys
this.
do you mean deletes instead of destroy?

[benm (inactive), 2013-03-01 13:03:47]

We should probably have a crbug for this.

[mnaganov (inactive), 2013-03-01 13:11:02]

Thanks!

We have b/7231897 for that.

https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
File android_webview/browser/aw_devtools_delegate.cc (right):

https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
android_webview/browser/aw_devtools_delegate.cc:36: // The call below destroys
this.
On 2013/03/01 13:02:35, benm wrote:
> do you mean deletes instead of destroy?

I have copied this comment from another implementation :)
Updated for clarity.

[commit-bot: I haz the power, 2013-03-01 13:12:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/12378011/10002

[mnaganov (inactive), 2013-03-01 16:23:44]

Committed patchset #3 manually as r185543 (presubmit successful).

[joth, 2013-03-01 19:28:56]

Silly me, I forgot to press send yesterday, but some minor comments anyway in
case you happen to be hacking in here again anytime...

Thanks for adding this!!

https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
File android_webview/browser/aw_devtools_delegate.cc (right):

https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
android_webview/browser/aw_devtools_delegate.cc:37:
devtools_http_handler_->Stop();
nit: I'd move the comment below the method:
  devtools_http_handler_->Stop();
  // WARNING: |this| has now been deleted by the method above.

https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
android_webview/browser/aw_devtools_delegate.cc:54: "\"GET\", \"/json/list?t=\"
+ new Date().getTime(), true);"
nit: you can use single quote ' in JS which won't need escaping, so should be 
more readable,.

[tenumm, 2013-07-26 17:30:54]

On 2013/03/01 19:28:56, joth wrote:
> Silly me, I forgot to press send yesterday, but some minor comments anyway in
> case you happen to be hacking in here again anytime...
> 
> Thanks for adding this!!
> 
>
https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
> File android_webview/browser/aw_devtools_delegate.cc (right):
> 
>
https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
> android_webview/browser/aw_devtools_delegate.cc:37:
> devtools_http_handler_->Stop();
> nit: I'd move the comment below the method:
>   devtools_http_handler_->Stop();
>   // WARNING: |this| has now been deleted by the method above.
> 
>
https://codereview.chromium.org/12378011/diff/5001/android_webview/browser/aw...
> android_webview/browser/aw_devtools_delegate.cc:54: "\"GET\",
\"/json/list?t=\"
> + new Date().getTime(), true);"
> nit: you can use single quote ' in JS which won't need escaping, so should be 
> more readable,.

How to run this with android webview apk?