Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1237763002: Support fractional desktopScale values in choosePluginDimensions. (Closed)

Created:
5 years, 5 months ago by Wez
Modified:
5 years, 5 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support fractional desktopScale values in choosePluginDimensions. Previously desktopScale was applied as part of the scale calculations, so that snapping to integer scale factors would take effect afterward. This lead to situations in which the client would be rendered 1:1 host:client device pixels at high-DPI clients, so effectively appearing down-scaled and often unusably small. choosePluginDimensions now adjusts the supplied client area dimensions to account for desktopScale as well as the client's devicePixelRatio. BUG=498346 Committed: https://crrev.com/7eb7b5d7b22886b30bf1e089ceb346914e5b6d24 Cr-Commit-Position: refs/heads/master@{#338707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M remoting/webapp/base/js/viewport.js View 4 chunks +7 lines, -13 lines 0 comments Download
M remoting/webapp/base/js/viewport_unittest.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Wez
5 years, 5 months ago (2015-07-14 06:24:58 UTC) #2
Sergey Ulanov
lgtm
5 years, 5 months ago (2015-07-14 16:18:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237763002/1
5 years, 5 months ago (2015-07-14 17:12:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 17:23:16 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 17:24:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eb7b5d7b22886b30bf1e089ceb346914e5b6d24
Cr-Commit-Position: refs/heads/master@{#338707}

Powered by Google App Engine
This is Rietveld 408576698