Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3133)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/standalone.gypi

Issue 1237753004: Add -Wshorten-64-to-32 flag to mac builds. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/base/platform/time.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 788b96e01b7e06ef54547daeac4d79770c68c7d1..2fba9a9c2a4856f30ddda94786e49c1c5bd66491 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -787,6 +787,12 @@
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++0x', # -std=gnu++0x
},
+ 'conditions': [
+ ['v8_target_arch=="x64" or v8_target_arch=="arm64" \
+ or v8_target_arch=="mips64el"', {
+ 'xcode_settings': {'WARNING_CFLAGS': ['-Wshorten-64-to-32']},
+ }],
+ ]
Jakob Kummerow 2015/07/14 13:16:09 nit: trailing ',' for consistency
balazs.kilvady 2015/07/14 15:42:44 Done.
}],
],
'target_conditions': [
« no previous file with comments | « no previous file | src/base/platform/time.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698