Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1237753004: Add -Wshorten-64-to-32 flag to mac builds. (Closed)

Created:
5 years, 5 months ago by balazs.kilvady
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add -Wshorten-64-to-32 flag to mac builds. BUG= Committed: https://crrev.com/30b39f25fc00e8aaba13a7ef911201cd6cb3fe73 Cr-Commit-Position: refs/heads/master@{#29652}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit, clang formatted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M build/standalone.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/base/platform/time.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/gdb-jit.cc View 1 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
balazs.kilvady
We would like to use Xcode/mac for development. V8-team reviewers, please take a look. These ...
5 years, 5 months ago (2015-07-14 12:12:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237753004/1
5 years, 5 months ago (2015-07-14 12:13:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 12:40:42 UTC) #6
Michael Achenbach
lgtm
5 years, 5 months ago (2015-07-14 13:14:28 UTC) #7
Jakob Kummerow
LGTM https://codereview.chromium.org/1237753004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1237753004/diff/1/build/standalone.gypi#newcode795 build/standalone.gypi:795: ] nit: trailing ',' for consistency
5 years, 5 months ago (2015-07-14 13:16:09 UTC) #8
balazs.kilvady
Also clang formatted. https://codereview.chromium.org/1237753004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1237753004/diff/1/build/standalone.gypi#newcode795 build/standalone.gypi:795: ] On 2015/07/14 13:16:09, Jakob wrote: ...
5 years, 5 months ago (2015-07-14 15:42:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237753004/20001
5 years, 5 months ago (2015-07-14 15:43:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-14 16:05:25 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 16:05:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30b39f25fc00e8aaba13a7ef911201cd6cb3fe73
Cr-Commit-Position: refs/heads/master@{#29652}

Powered by Google App Engine
This is Rietveld 408576698