Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1237713002: Dismissable component (Closed)

Created:
5 years, 5 months ago by hansmuller1
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dismissable component Lifted the code from the card_collection example. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fb0517a411ea19c8f3b56d9fc0319d0519a9296f

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Updated per review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -130 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/widgets/card_collection.dart View 1 4 chunks +22 lines, -130 lines 0 comments Download
A sky/sdk/lib/widgets/dismissable.dart View 1 1 chunk +165 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hansmuller
PTAL
5 years, 5 months ago (2015-07-13 18:42:29 UTC) #4
abarth-chromium
lgtm https://codereview.chromium.org/1237713002/diff/20001/sky/sdk/example/widgets/card_collection.dart File sky/sdk/example/widgets/card_collection.dart (right): https://codereview.chromium.org/1237713002/diff/20001/sky/sdk/example/widgets/card_collection.dart#newcode51 sky/sdk/example/widgets/card_collection.dart:51: key: "${cardIndex}", cardIndex.toString() https://codereview.chromium.org/1237713002/diff/20001/sky/sdk/lib/widgets/dismissable.dart File sky/sdk/lib/widgets/dismissable.dart (right): https://codereview.chromium.org/1237713002/diff/20001/sky/sdk/lib/widgets/dismissable.dart#newcode20 ...
5 years, 5 months ago (2015-07-13 19:20:17 UTC) #6
hansmuller
https://codereview.chromium.org/1237713002/diff/20001/sky/sdk/example/widgets/card_collection.dart File sky/sdk/example/widgets/card_collection.dart (right): https://codereview.chromium.org/1237713002/diff/20001/sky/sdk/example/widgets/card_collection.dart#newcode51 sky/sdk/example/widgets/card_collection.dart:51: key: "${cardIndex}", On 2015/07/13 19:20:16, abarth-chromium wrote: > cardIndex.toString() ...
5 years, 5 months ago (2015-07-13 19:34:38 UTC) #7
hansmuller1
5 years, 5 months ago (2015-07-13 19:44:10 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
fb0517a411ea19c8f3b56d9fc0319d0519a9296f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698