Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 12377088: Revert 184747 (Closed)

Created:
7 years, 9 months ago by kerz_chromium
Modified:
7 years, 9 months ago
Reviewers:
greggman
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Revert 184747 > Merge 184718 - ChromeFrame sites in IE would appear truncated at times. > > This was a regression caused by the change to invalidate the cached protocol data when IE (urlmon) > terminates the protocol. While this works well for non CF requests, for CF requests when we report > the changed mime type to be that of chrome, the protocol is terminated with cached data. When Chrome > attempts to read it we don't have anything to report which leads to the problem. > > Fix is to not invalidate the protocol data for Chrome requests in our Terminate hook. We should invalidate > it for Abort because that seems like an error condition. > > BUG=178421 > R=robertshield. > Review URL: https://chromiumcodereview.appspot.com/12310145 > > TBR=ananta@chromium.org > Review URL: https://chromiumcodereview.appspot.com/12314131 TBR=gman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome_frame/protocol_sink_wrap.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kerz_chromium
7 years, 9 months ago (2013-03-04 20:20:07 UTC) #1
kerz_chromium
7 years, 9 months ago (2013-03-04 20:20:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r185958.

Powered by Google App Engine
This is Rietveld 408576698