Recognize more list factories. Recognizing list factories (Array, Bytearrays, etc) allows the type …

runtime/vm/intrinsifier.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Class for intrinsifying functions.
 
 #ifndef VM_INTRINSIFIER_H_
 #define VM_INTRINSIFIER_H_
 
 #include "vm/allocation.h"
 
@@ skipping 70 matching lines @@
   V(_StringBase, codeUnitAt, String_codeUnitAt, 984449525)                     \
   V(_OneByteString, get:hashCode, OneByteString_getHashCode, 682660413)        \
 
 
 #define MATH_LIB_INTRINSIC_LIST(V)                                             \
   V(::, sqrt, Math_sqrt, 1662640002)                                           \
   V(::, sin, Math_sin, 1273932041)                                             \
   V(::, cos, Math_cos, 1749547468)                                             \
 
 
+// Note that any intrinsified function is not inlined. Some optimizations
+// rely on seeing the factories below instead of their inlined code.
 #define SCALARLIST_LIB_INTRINSIC_LIST(V)                                       \
   V(_ByteArrayBase, get:length, ByteArrayBase_getLength, 1098081765)           \
-  V(_Int8Array, _new, Int8Array_new, 535958453)                                \
-  V(_Uint8Array, _new, Uint8Array_new, 604355565)                              \
-  V(_Uint8ClampedArray, _new, Uint8ClampedArray_new, 1070949952)               \
-  V(_Int16Array, _new, Int16Array_new, 903723993)                              \
-  V(_Uint16Array, _new, Uint16Array_new, 133542762)                            \
-  V(_Int32Array, _new, Int32Array_new, 8218286)                                \
-  V(_Uint32Array, _new, Uint32Array_new, 469402161)                            \
+  V(Int8List, ., Int8Array_new, 817410959)                                     \
+  V(Uint8List, ., Uint8Array_new, 220896178)                                   \
+  V(Uint8ClampedList, ., Uint8ClampedArray_new, 422034060)                     \
+  V(Int16List, ., Int16Array_new, 214246025)                                   \
+  V(Uint16List, ., Uint16Array_new, 137929963)                                 \
+  V(Int32List, ., Int32Array_new, 1977571010)                                  \
+  V(Uint32List, ., Uint32Array_new, 407638944)                                 \
   V(_Int64Array, [], Int64Array_getIndexed, 504894128)                         \
-  V(_Int64Array, _new, Int64Array_new, 60605075)                               \
+  V(Int64List, ., Int64Array_new, 885130273)                                   \
   V(_Uint64Array, [], Uint64Array_getIndexed, 31272531)                        \
-  V(_Uint64Array, _new, Uint64Array_new, 624354107)                            \
-  V(_Float32Array, _new, Float32Array_new, 109944959)                          \

[Vyacheslav Egorov (Google), 2013/03/04 19:39:28]

I wonder if we can kill _new?

[srdjan, 2013/03/04 21:37:07]

As discussed, added _new for all byte array classes since getRange needs it.

-  V(_Float64Array, _new, Float64Array_new, 147668392)                          \
+  V(Uint64List, ., Uint64Array_new, 1471017221)                                \
+  V(Float32List, ., Float32Array_new, 2035252095)                              \
+  V(Float64List, ., Float64Array_new, 1037441059)                              \
 
 
 // TODO(srdjan): Implement _FixedSizeArrayIterator, get:current and
 //   _FixedSizeArrayIterator, moveNext.
 
 // Forward declarations.
 class Assembler;
 class Function;
 
 class Intrinsifier : public AllStatic {
@@ skipping 12 matching lines @@
   CORE_LIB_INTRINSIC_LIST(DECLARE_FUNCTION)
   MATH_LIB_INTRINSIC_LIST(DECLARE_FUNCTION)
   SCALARLIST_LIB_INTRINSIC_LIST(DECLARE_FUNCTION)
 
 #undef DECLARE_FUNCTION
 };
 
 }  // namespace dart
 
 #endif  // VM_INTRINSIFIER_H_