Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: chrome/browser/search_engines/template_url_service.cc

Issue 12377080: Don't log anything if the user has a NULL default search provider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url_service.cc
diff --git a/chrome/browser/search_engines/template_url_service.cc b/chrome/browser/search_engines/template_url_service.cc
index b9124d5d1fba331efb98959c0f0e8f4291ca8059..c6e50a977f7b2eed4c16e9ab062985d1f3eb2046 100644
--- a/chrome/browser/search_engines/template_url_service.cc
+++ b/chrome/browser/search_engines/template_url_service.cc
@@ -826,11 +826,13 @@ void TemplateURLService::OnWebDataServiceRequestDone(
SetDefaultSearchProviderNoNotify(FindNewDefaultSearchProvider());
DCHECK(success);
}
- UMA_HISTOGRAM_ENUMERATION(
- kDSPHistogramName,
- default_search_provider_ ?
- default_search_provider_->prepopulate_id() : 0,
- TemplateURLPrepopulateData::kMaxPrepopulatedEngineID);
+ // Don't log anything if the user has a NULL default search provider.
SteveT 2013/03/04 15:49:28 nit: Expand your comment a bit "Note that this mea
+ if (default_search_provider_) {
+ UMA_HISTOGRAM_ENUMERATION(
+ kDSPHistogramName,
+ default_search_provider_->prepopulate_id(),
+ TemplateURLPrepopulateData::kMaxPrepopulatedEngineID);
+ }
}
NotifyObservers();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698