Chromium Code Reviews| Index: chrome/browser/search_engines/template_url_service.cc |
| diff --git a/chrome/browser/search_engines/template_url_service.cc b/chrome/browser/search_engines/template_url_service.cc |
| index b9124d5d1fba331efb98959c0f0e8f4291ca8059..c6e50a977f7b2eed4c16e9ab062985d1f3eb2046 100644 |
| --- a/chrome/browser/search_engines/template_url_service.cc |
| +++ b/chrome/browser/search_engines/template_url_service.cc |
| @@ -826,11 +826,13 @@ void TemplateURLService::OnWebDataServiceRequestDone( |
| SetDefaultSearchProviderNoNotify(FindNewDefaultSearchProvider()); |
| DCHECK(success); |
| } |
| - UMA_HISTOGRAM_ENUMERATION( |
| - kDSPHistogramName, |
| - default_search_provider_ ? |
| - default_search_provider_->prepopulate_id() : 0, |
| - TemplateURLPrepopulateData::kMaxPrepopulatedEngineID); |
| + // Don't log anything if the user has a NULL default search provider. |
|
SteveT
2013/03/04 15:49:28
nit: Expand your comment a bit "Note that this mea
|
| + if (default_search_provider_) { |
| + UMA_HISTOGRAM_ENUMERATION( |
| + kDSPHistogramName, |
| + default_search_provider_->prepopulate_id(), |
| + TemplateURLPrepopulateData::kMaxPrepopulatedEngineID); |
| + } |
| } |
| NotifyObservers(); |