Issue 12377080: Don't log anything if the user has a NULL default search provider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12377080: Don't log anything if the user has a NULL default search provider. (Closed)

Created:
7 years, 9 months ago by beaudoin

Modified:
7 years, 9 months ago

Reviewers:
SteveT, Steve

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't log anything if the user has a NULL default search provider. BUG=179847 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185937

Patch Set 2 : Fixed comment. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	chrome/browser/search_engines/template_url_service.cc	View	1	1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

SteveT

LGTM. https://codereview.chromium.org/12377080/diff/1/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): https://codereview.chromium.org/12377080/diff/1/chrome/browser/search_engines/template_url_service.cc#newcode829 chrome/browser/search_engines/template_url_service.cc:829: // Don't log anything if the user has ...

7 years, 9 months ago (2013-03-04 15:49:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/12377080/5001

7 years, 9 months ago (2013-03-04 16:11:41 UTC) #3

Message was sent while issue was closed.

Change committed as 185937

Expand Messages | Collapse Messages

Issue 12377080: Don't log anything if the user has a NULL default search provider. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed comment. #

Messages