Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 12377080: Don't log anything if the user has a NULL default search provider. (Closed)

Created:
7 years, 9 months ago by beaudoin
Modified:
7 years, 9 months ago
Reviewers:
SteveT, Steve
CC:
chromium-reviews
Visibility:
Public.

Description

Don't log anything if the user has a NULL default search provider. BUG=179847 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185937

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/search_engines/template_url_service.cc View 1 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
beaudoin
7 years, 9 months ago (2013-03-04 15:48:03 UTC) #1
SteveT
LGTM. https://codereview.chromium.org/12377080/diff/1/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): https://codereview.chromium.org/12377080/diff/1/chrome/browser/search_engines/template_url_service.cc#newcode829 chrome/browser/search_engines/template_url_service.cc:829: // Don't log anything if the user has ...
7 years, 9 months ago (2013-03-04 15:49:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/12377080/5001
7 years, 9 months ago (2013-03-04 16:11:41 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-04 18:42:48 UTC) #4
Message was sent while issue was closed.
Change committed as 185937

Powered by Google App Engine
This is Rietveld 408576698