Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 12377059: Migrate master.chromium.linux to Precise. (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.
Modified:
7 years, 9 months ago
CC:
chromium-reviews, cmp-cc_chromium.org
Visibility:
Public.

Description

Migrate master.chromium.linux to Precise. - add 32-bit Precise dbg builder and switch 32-bit Precise testers to it - add Precise bots to gatekeeper - remove now unused temporary Precise bots in favor of new ones - remove Lucid Linux bots from chromium.linux BUG=170262 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187176

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -282 lines) Patch
M build/masters/master.chromium.linux/master_linux_cfg.py View 1 2 3 4 12 chunks +58 lines, -196 lines 0 comments Download
M build/masters/master.chromium.linux/slaves.cfg View 1 2 3 5 chunks +14 lines, -86 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-04 17:43:19 UTC) #1
Marc-Antoine Ruel (Google)
https://codereview.chromium.org/12377059/diff/1/build/masters/master.chromium.linux/master_linux_cfg.py File build/masters/master.chromium.linux/master_linux_cfg.py (right): https://codereview.chromium.org/12377059/diff/1/build/masters/master.chromium.linux/master_linux_cfg.py#newcode93 build/masters/master.chromium.linux/master_linux_cfg.py:93: rel_precise_archive = master_config.GetArchiveUrl( Why not remove "precise" from everywhere?
7 years, 9 months ago (2013-03-05 02:34:56 UTC) #2
iannucci
Oops... I had the same comment, forgot to publish :/ https://codereview.chromium.org/12377059/diff/1/build/masters/master.chromium.linux/master_linux_cfg.py File build/masters/master.chromium.linux/master_linux_cfg.py (left): https://codereview.chromium.org/12377059/diff/1/build/masters/master.chromium.linux/master_linux_cfg.py#oldcode122 ...
7 years, 9 months ago (2013-03-05 03:30:41 UTC) #3
Paweł Hajdan Jr.
PTAL Cleaned up the names.
7 years, 9 months ago (2013-03-05 19:10:03 UTC) #4
Paweł Hajdan Jr.
+Isaac
7 years, 9 months ago (2013-03-05 20:48:50 UTC) #5
Dirk Pranke
drive-by lgtm ... :).
7 years, 9 months ago (2013-03-06 00:19:53 UTC) #6
iannucci
This looks pretty lgtm too. When you commit+deploy, just make sure you hang around until ...
7 years, 9 months ago (2013-03-06 00:30:32 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/12377059/diff/5001/build/masters/master.chromium.linux/master_linux_cfg.py File build/masters/master.chromium.linux/master_linux_cfg.py (right): https://codereview.chromium.org/12377059/diff/5001/build/masters/master.chromium.linux/master_linux_cfg.py#newcode125 build/masters/master.chromium.linux/master_linux_cfg.py:125: 'linux_rel_trigger', On 2013/03/06 00:30:33, iannucci wrote: > I don't ...
7 years, 9 months ago (2013-03-06 00:38:20 UTC) #8
Paweł Hajdan Jr.
Tony, could you take a look at this change? Isaac raised concerns about chromium.linux using ...
7 years, 9 months ago (2013-03-06 00:39:49 UTC) #9
tony
Isaac asked me about this IRL. I think this is fine, but it would be ...
7 years, 9 months ago (2013-03-06 00:43:13 UTC) #10
tony
LGTM. Paweł tells me we already have precise try bots so we should be able ...
7 years, 9 months ago (2013-03-06 00:47:02 UTC) #11
Isaac (away)
LGTM after https://codereview.chromium.org/12456007/ is landed, takes affect, and is verified as working.
7 years, 9 months ago (2013-03-06 01:07:58 UTC) #12
Paweł Hajdan Jr.
Committed patchset #5 manually as r187176 (presubmit successful).
7 years, 9 months ago (2013-03-10 00:25:45 UTC) #13
Isaac (away)
This broke LKGR finder. Again. It is still pointing to Linux Builder x64 which is ...
7 years, 9 months ago (2013-03-17 07:24:08 UTC) #14
Isaac (away)
7 years, 9 months ago (2013-03-17 07:30:39 UTC) #15
Message was sent while issue was closed.
Hmm.  I'm incorrect.  LKGR is stuck for a different reason.  Gclient synced my
local tree to an old revision and I got the error from Linux (x64) not found
(and didn't see your change to lkgr_finder to point to new bots).  Sorry.

Powered by Google App Engine
This is Rietveld 408576698