Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 12377029: Get rid of WebLayerTreeViewClient references in WebLayerTreeViewImplForTesting (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Get rid of WebLayerTreeViewClient references in WebLayerTreeViewImplForTesting Follow-up to r185341 / WebKit r144398 The only client this class needs is the DRTLayerTreeViewClient. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -278 lines) Patch
M webkit/compositor_bindings/compositor_bindings_tests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/compositor_bindings/test/web_layer_tree_view_test_common.h View 1 chunk +0 lines, -37 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.h View 3 chunks +1 line, -7 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.cc View 4 chunks +2 lines, -15 lines 0 comments Download
D webkit/compositor_bindings/web_layer_unittest.cc View 1 chunk +0 lines, -195 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/support/webkit_support.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webkit/support/webkit_support.cc View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jamesr
Depends on https://bugs.webkit.org/show_bug.cgi?id=111017 landing + rolling in
7 years, 9 months ago (2013-02-28 22:21:43 UTC) #1
danakj
On Thu, Feb 28, 2013 at 2:21 PM, <jamesr@chromium.org> wrote: > Reviewers: enne, > > ...
7 years, 9 months ago (2013-02-28 22:38:38 UTC) #2
jamesr
On 2013/02/28 22:38:38, danakj wrote: > On Thu, Feb 28, 2013 at 2:21 PM, <mailto:jamesr@chromium.org> ...
7 years, 9 months ago (2013-02-28 22:43:07 UTC) #3
jamesr
WebKit side landed (but not yet rolled): http://trac.webkit.org/changeset/144398
7 years, 9 months ago (2013-03-01 00:52:38 UTC) #4
enne (OOO)
lgtm
7 years, 9 months ago (2013-03-01 04:14:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12377029/1
7 years, 9 months ago (2013-03-01 21:54:22 UTC) #6
jamesr
7 years, 9 months ago (2013-03-02 02:19:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r185662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698