Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 12377018: Revert 144157 (Closed)

Created:
7 years, 9 months ago by karen
Modified:
7 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1425/
Visibility:
Public.

Description

Revert 144157 > [V8] Generate a wrapper function for named constructor callbacks > https://bugs.webkit.org/show_bug.cgi?id=110794 > > Reviewed by Adam Barth. > > This would be the final step of generating wrapper functions. > The patch generates the following wrapper function for named > constructor callbacks. > > Handle<Value> namedConstructorCallback(...) > { > return namedConstructor(...); > } > > No tests. No change in behavior. > > * bindings/scripts/CodeGeneratorV8.pm: > (GenerateNamedConstructor): > * bindings/scripts/test/V8/V8TestNamedConstructor.cpp: > (WebCore::namedConstructor): > (WebCore::namedConstructorCallback): > (WebCore): > (WebCore::V8TestNamedConstructorConstructor::GetTemplate): > * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: > (WebCore::namedConstructor): > (WebCore::namedConstructorCallback): > (WebCore): > (WebCore::V8HTMLImageElementConstructor::GetTemplate): > TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M Source/WebCore/bindings/scripts/CodeGeneratorV8.pm View 4 chunks +10 lines, -9 lines 0 comments Download
M Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
7 years, 9 months ago (2013-02-28 15:24:05 UTC) #1
karen
7 years, 9 months ago (2013-02-28 15:24:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r144313.

Powered by Google App Engine
This is Rietveld 408576698