Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 12377016: mac: Don't do our Chinese Handwriting IME hack on OS X 10.9+ (Closed)

Created:
7 years, 9 months ago by Nico
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, sail+watch_chromium.org
Visibility:
Public.

Description

mac: Don't do our Chinese Handwriting IME hack on OS X 10.9+ The bug this works around is reportedly fixed. BUG=179034, 31225, 152566 TEST=see bug 31225 TBR=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185244

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M content/renderer/renderer_main_platform_delegate_mac.mm View 3 chunks +30 lines, -24 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
Nico
7 years, 9 months ago (2013-02-28 13:38:01 UTC) #1
Bernhard Bauer
lgtm https://codereview.chromium.org/12377016/diff/2001/content/renderer/renderer_main_platform_delegate_mac.mm File content/renderer/renderer_main_platform_delegate_mac.mm (right): https://codereview.chromium.org/12377016/diff/2001/content/renderer/renderer_main_platform_delegate_mac.mm#newcode144 content/renderer/renderer_main_platform_delegate_mac.mm:144: bool needs_ime_hack = !base::mac::IsOSLaterThanMountainLion_DontCallThis(); Bwahaha
7 years, 9 months ago (2013-02-28 13:50:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12377016/2001
7 years, 9 months ago (2013-02-28 13:51:12 UTC) #3
commit-bot: I haz the power
Presubmit check for 12377016-2001 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-02-28 13:51:14 UTC) #4
Nico
jamesr: content/renderer/OWNERS tbr
7 years, 9 months ago (2013-02-28 13:51:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12377016/2001
7 years, 9 months ago (2013-02-28 13:51:57 UTC) #6
Robert Sesek
LGTM
7 years, 9 months ago (2013-02-28 14:08:40 UTC) #7
Nico
Committed patchset #2 manually as r185244 (presubmit successful).
7 years, 9 months ago (2013-02-28 14:49:33 UTC) #8
jamesr
7 years, 9 months ago (2013-02-28 20:25:26 UTC) #9
Message was sent while issue was closed.
I'll handwrite your Chinese!

lgtm

https://codereview.chromium.org/12377016/diff/2001/content/renderer/renderer_...
File content/renderer/renderer_main_platform_delegate_mac.mm (right):

https://codereview.chromium.org/12377016/diff/2001/content/renderer/renderer_...
content/renderer/renderer_main_platform_delegate_mac.mm:148:
(void*)&TISCreateInputSourceList,
why the c-style casts?

Powered by Google App Engine
This is Rietveld 408576698