Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 12377004: Linux: Fix a target to depend on the allocator target, so it builds properly with system ld. (Closed)

Created:
7 years, 9 months ago by Lei Zhang
Modified:
7 years, 9 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Linux: Fix a target to depend on the allocator target, so it builds properly with system ld. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/content_tests.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
Fixes the error from http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos_clang/builds/11532/steps/compile/logs/stdio FAILED: flock linker.lock clang++ -Wl,-z,now -Wl,-z,relro -pthread -Wl,-z,noexecstack -fPIC -L. ...
7 years, 9 months ago (2013-02-28 00:32:32 UTC) #1
Dirk Pranke
On 2013/02/28 00:32:32, Lei Zhang wrote: > Fixes the error from > http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos_clang/builds/11532/steps/compile/logs/stdio > > ...
7 years, 9 months ago (2013-02-28 00:38:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12377004/1
7 years, 9 months ago (2013-02-28 00:40:42 UTC) #3
commit-bot: I haz the power
Presubmit check for 12377004-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-02-28 00:40:44 UTC) #4
Lei Zhang
+jam for content OWNERS
7 years, 9 months ago (2013-02-28 00:47:03 UTC) #5
jam
lgtm
7 years, 9 months ago (2013-02-28 02:33:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12377004/1
7 years, 9 months ago (2013-02-28 02:43:19 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=14841
7 years, 9 months ago (2013-02-28 05:55:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12377004/1
7 years, 9 months ago (2013-02-28 07:21:39 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 10:42:32 UTC) #10
Message was sent while issue was closed.
Change committed as 185210

Powered by Google App Engine
This is Rietveld 408576698