Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1237693005: Document new CQ keyword (Closed)

Created:
5 years, 5 months ago by rmistry
Modified:
5 years, 5 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M site/dev/contrib/cqkeywords.md View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
rmistry
5 years, 5 months ago (2015-07-15 11:39:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237693005/1
5 years, 5 months ago (2015-07-15 11:40:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7e797dff24f3a256fc6e5b5d0a366fb90c93ff18
5 years, 5 months ago (2015-07-15 11:40:58 UTC) #5
jcgregorio
https://codereview.chromium.org/1237693005/diff/1/site/dev/contrib/cqkeywords.md File site/dev/contrib/cqkeywords.md (right): https://codereview.chromium.org/1237693005/diff/1/site/dev/contrib/cqkeywords.md#newcode19 site/dev/contrib/cqkeywords.md:19: The CQ rejects patchsets with open dependencies. You can ...
5 years, 5 months ago (2015-07-15 19:36:21 UTC) #6
rmistry
On 2015/07/15 19:36:21, jcgregorio wrote: > https://codereview.chromium.org/1237693005/diff/1/site/dev/contrib/cqkeywords.md > File site/dev/contrib/cqkeywords.md (right): > > https://codereview.chromium.org/1237693005/diff/1/site/dev/contrib/cqkeywords.md#newcode19 > ...
5 years, 5 months ago (2015-07-15 19:59:05 UTC) #7
jcgregorio
5 years, 5 months ago (2015-07-15 20:04:51 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1237693005/diff/1/site/dev/contrib/cqkeywords.md
File site/dev/contrib/cqkeywords.md (right):

https://codereview.chromium.org/1237693005/diff/1/site/dev/contrib/cqkeywords...
site/dev/contrib/cqkeywords.md:19: The CQ rejects patchsets with open
dependencies. You can skip this check with this keyword.
Can we add that to the docs?

On 2015/07/15 at 19:36:20, jcgregorio wrote:
> What is an "open dependency"?

Powered by Google App Engine
This is Rietveld 408576698