Issue 1237623014: relnote: Convert the map into a list in QuicStreamSequencer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1237623014: relnote: Convert the map into a list in QuicStreamSequencer. (Closed)

Created:
5 years, 5 months ago by ramant (doing other things)

Modified:
5 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Allow_QuicClient_to_set_MTU_97160807

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

relnote: Convert the map into a list in QuicStreamSequencer. Merge internal change: 97162517 Added missing RandomFramesNoDroppingBackup unittest. R=rch@chromium.org

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+175 lines, -93 lines)			Patch
M	net/quic/quic_stream_sequencer.h	View	3 chunks	+24 lines, -11 lines	0 comments	Download
M	net/quic/quic_stream_sequencer.cc	View	11 chunks	+100 lines, -81 lines	0 comments	Download
M	net/quic/quic_stream_sequencer_test.cc	View	2 chunks	+48 lines, -0 lines	1 comment	Download
M	net/quic/test_tools/quic_stream_sequencer_peer.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1240953002 Patch 20001

Dependent Patchsets:

Issue 1232793004 Patch 1

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

https://codereview.chromium.org/1237623014/diff/1/net/quic/quic_stream_sequencer_test.cc File net/quic/quic_stream_sequencer_test.cc (right): https://codereview.chromium.org/1237623014/diff/1/net/quic/quic_stream_sequencer_test.cc#newcode391 net/quic/quic_stream_sequencer_test.cc:391: TEST_F(QuicSequencerRandomTest, RandomFramesNoDroppingBackup) { Hi Ryan, While porting this CL, ...

5 years, 5 months ago (2015-07-17 01:27:46 UTC) #2

LGTM!

Expand Messages | Collapse Messages