Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1237623012: Fix textureDomain/bleed prevention in msaa (Closed)

Created:
5 years, 5 months ago by robertphillips
Modified:
5 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix textureDomain/bleed prevention in msaa This updates Ganesh's bleed avoidance check to handle the case where the sample location may be outside of the rect geometry but used because it partially covers the pixel. BUG=skia:4066 Committed: https://skia.googlesource.com/skia/+/1accc4cc35a1360c086fd8ffab9f6f4e3948ed7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/gpu/SkGpuDevice.cpp View 5 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
robertphillips
5 years, 5 months ago (2015-07-15 20:58:13 UTC) #2
bsalomon
On 2015/07/15 20:58:13, robertphillips wrote: lgtm
5 years, 5 months ago (2015-07-15 21:08:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237623012/1
5 years, 5 months ago (2015-07-20 17:15:19 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 17:22:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1accc4cc35a1360c086fd8ffab9f6f4e3948ed7b

Powered by Google App Engine
This is Rietveld 408576698