Issue 1237623004: Remove onFrame callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1237623004: Remove onFrame callback (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove onFrame callback Clients can just register persistent frame callbacks if they want to do some processing every frame. Also, add some more trace events. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/9f9555512aada3fcc0a68ef7517b07c23465a1f2

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -18 lines)			Patch
M	sky/sdk/example/widgets/block_viewport.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sky/sdk/example/widgets/sector.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/sdk/example/widgets/styled_text.dart	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	sky/sdk/lib/rendering/README.md	View	1 chunk	+4 lines, -1 line	1 comment	Download
M	sky/sdk/lib/rendering/object.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	sky/sdk/lib/rendering/sky_binding.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1237623004/diff/1/sky/sdk/lib/rendering/README.md File sky/sdk/lib/rendering/README.md (right): https://codereview.chromium.org/1237623004/diff/1/sky/sdk/lib/rendering/README.md#newcode370 sky/sdk/lib/rendering/README.md:370: This is a quick way to dump the ...

5 years, 5 months ago (2015-07-13 20:35:09 UTC) #2

abarth-chromium

5 years, 5 months ago (2015-07-13 20:43:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9f9555512aada3fcc0a68ef7517b07c23465a1f2 (presubmit successful).

Expand Messages | Collapse Messages