Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1237603002: Enable loads and stores to global vars through property cell shortcuts installed into parent script… (Closed)

Created:
5 years, 5 months ago by Igor Sheludko
Modified:
5 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable loads and stores to global vars through property cell shortcuts installed into parent script context. Committed: https://crrev.com/cd61b047f1ab92c353a629556f9d3ad571ace1b1 Cr-Commit-Position: refs/heads/master@{#29595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Igor Sheludko
PTAL
5 years, 5 months ago (2015-07-13 09:44:28 UTC) #2
Toon Verwaest
lgtm
5 years, 5 months ago (2015-07-13 10:20:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237603002/1
5 years, 5 months ago (2015-07-13 10:20:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 10:22:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cd61b047f1ab92c353a629556f9d3ad571ace1b1 Cr-Commit-Position: refs/heads/master@{#29595}
5 years, 5 months ago (2015-07-13 10:22:18 UTC) #7
Michael Achenbach
On 2015/07/13 10:22:18, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 5 months ago (2015-07-13 11:16:53 UTC) #8
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1236863002/ by machenbach@chromium.org. ...
5 years, 5 months ago (2015-07-13 11:19:09 UTC) #9
Michael Achenbach
5 years, 5 months ago (2015-07-13 12:53:42 UTC) #10
Message was sent while issue was closed.
On 2015/07/13 11:19:09, Michael Achenbach wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1236863002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] This changes lots of layout tests. See
> comment on CL..

Also caused this:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...

Powered by Google App Engine
This is Rietveld 408576698