src/typedarray.js - Issue 1237583005: Only evaluate length once in %TypedArray%.prototype.set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typedarray.js

Issue 1237583005: Only evaluate length once in %TypedArray%.prototype.set (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add more cases to the test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typedarray.js

diff --git a/src/typedarray.js b/src/typedarray.js

index ce52cdf15c0b50db12eb9c904fd1781ce30acf26..8e18b5e66e08755ec7f9389530eef640100b4119 100644

--- a/src/typedarray.js

+++ b/src/typedarray.js

@@ -330,6 +330,7 @@ function TypedArraySet(obj, offset) {

}

return;

}

+ l = $toLength(l);

if (intOffset + l > this.length) {

throw MakeRangeError(kTypedArraySetSourceTooLarge);

}

« no previous file with comments | « no previous file | test/mjsunit/es6/typedarray-set-length.js » ('j') | no next file with comments »