Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1237563004: Remove duplicate color used in EB ActionBar. (Closed)

Created:
5 years, 5 months ago by aurimas (slooooooooow)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate color used in EB ActionBar. - enhanced_bookmark_drawer_selected_color is very close to light_active_color (it is really difficult to tell them apart) - enhanced_bookmark_selection_action_bar_background is similar to light_active_color BUG=510941 Committed: https://crrev.com/983bc7cb4593bba22510e31ab73e33c21231e009 Cr-Commit-Position: refs/heads/master@{#339118}

Patch Set 1 #

Patch Set 2 : Remove another color #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/android/java/res/color/eb_drawer_text_color.xml View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 5 months ago (2015-07-16 19:47:51 UTC) #2
Kibeom Kim (inactive)
lgtm thanks!
5 years, 5 months ago (2015-07-16 20:06:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237563004/20001
5 years, 5 months ago (2015-07-16 20:12:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-16 21:01:53 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 21:04:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/983bc7cb4593bba22510e31ab73e33c21231e009
Cr-Commit-Position: refs/heads/master@{#339118}

Powered by Google App Engine
This is Rietveld 408576698