Uses Hash values for sparse histograms for InputMethod.ID statistics.

chrome/browser/chromeos/input_method/input_method_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/input_method_manager_impl.h"
 
 #include <algorithm>  // std::find
 
 #include <sstream>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
+#include "base/hash.h"
 #include "base/location.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/sys_info.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 833 matching lines @@
 
   // Initializes the system IME list.
   scoped_ptr<ComponentExtensionIMEManagerDelegate> comp_delegate(
       new ComponentExtensionIMEManagerImpl());
   component_extension_ime_manager_->Initialize(comp_delegate.Pass());
   const InputMethodDescriptors& descriptors =
       component_extension_ime_manager_->GetAllIMEAsInputMethodDescriptor();
   util_.ResetInputMethods(descriptors);
 
   // Initializes the stat id map.
-  std::map<int, std::vector<std::string> > buckets;
   for (InputMethodDescriptors::const_iterator it = descriptors.begin();
        it != descriptors.end(); ++it) {
-    char first_char;
-    int cat_id = static_cast<int>(
-        GetInputMethodCategory(it->id(), &first_char));
-    int key = cat_id * 1000 + first_char;
-    buckets[key].push_back(it->id());
-  }
-  for (std::map<int, std::vector<std::string>>::iterator i =
-       buckets.begin(); i != buckets.end(); ++i) {
-    std::sort(i->second.begin(), i->second.end());
-    for (size_t j = 0; j < i->second.size() && j < 100; ++j) {
-      int key = i->first * 100 + j;
-      stat_id_map_[i->second[j]] = key;
-    }
+    std::string id = it->id();
+    stat_id_map_[id] =
+        static_cast<int>(base::SuperFastHash(id.c_str(), id.length()));

[Ilya Sherman, 2015/07/17 01:43:58]

nit: Rather than static_cast<int>, please use base::strict_cast, and cast to
int32_t or base::HistogramBase::Sample.

[Ilya Sherman, 2015/07/17 01:43:58]

Do you actually need this map anymore?  I think you could just directly hash at
the histogram logging site.

[Ilya Sherman, 2015/07/17 01:43:58]

nit: Any reason not to call this as "base::Hash(id)"?  If the lack of
BASE_EXPORT is the problem, I bet it's fine to add it -- I see no reason why the
convenience wrappers would not be exported.

[Shu Chen, 2015/07/17 03:55:50]

There will be compiling errors as below. I want to cast uint32 to int32 here.

../../base/numerics/safe_conversions.h:70:3: error: static_assert failed "The
numeric conversion is out of range for this type. You should probably use one of
the following conversion mechanisms on the value you want to pass:\n-
base::checked_cast\n- base::saturated_cast\n- base::CheckedNumeric"
  static_assert((internal::StaticDstRangeRelationToSrcRange<Dst, Src>::value ==
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../chrome/browser/chromeos/input_method/input_method_manager_impl.cc:886:56:
note: in instantiation of function template specialization
'base::strict_cast<int, unsigned int>' requested here
  UMA_HISTOGRAM_SPARSE_SLOWLY("InputMethod.ID2", base::strict_cast<int32_t>(
...

[Shu Chen, 2015/07/17 03:55:50]

Done.

[Shu Chen, 2015/07/17 03:55:50]

The reason was simply because I'd like it be super fast. :)
I've now changed to use base::Hash.

   }
 }
 
 InputMethodManagerImpl::~InputMethodManagerImpl() {
   if (candidate_window_controller_.get())
     candidate_window_controller_->RemoveObserver(this);
 }
 
 void InputMethodManagerImpl::RecordInputMethodUsage(
     std::string input_method_id) {
   UMA_HISTOGRAM_ENUMERATION("InputMethod.Category",
                             GetInputMethodCategory(input_method_id),
                             INPUT_METHOD_CATEGORY_MAX);
-  UMA_HISTOGRAM_SPARSE_SLOWLY("InputMethod.ID",
-                              stat_id_map_[input_method_id]);
+  UMA_HISTOGRAM_SPARSE_SLOWLY("InputMethod.ID2", stat_id_map_[input_method_id]);
 }
 
 void InputMethodManagerImpl::AddObserver(
     InputMethodManager::Observer* observer) {
   observers_.AddObserver(observer);
 }
 
 void InputMethodManagerImpl::AddCandidateWindowObserver(
     InputMethodManager::CandidateWindowObserver* observer) {
   candidate_window_observers_.AddObserver(observer);
@@ skipping 259 matching lines @@
   if (candidate_window_controller_.get())
     return;
 
   candidate_window_controller_.reset(
       CandidateWindowController::CreateCandidateWindowController());
   candidate_window_controller_->AddObserver(this);
 }
 
 }  // namespace input_method
 }  // namespace chromeos