Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1237453008: relnote: Call methods to handle QUIC frames immediately instead of (Closed)

Created:
5 years, 5 months ago by ramant (doing other things)
Modified:
5 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@Change_QuicConnectionVisitorInterface_97339157
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Call methods to handle QUIC frames immediately instead of waiting for all to be processed. Protected by FLAGS_quic_process_frames_inline Saves ~2% of CPU. Merge internal change: 97354883 Changed QuicHttpStreamTest to work with the new flag. R=rch@chromium.org

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -55 lines) Patch
M net/quic/quic_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 12 chunks +113 lines, -53 lines 2 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 4 chunks +17 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
5 years, 5 months ago (2015-07-17 23:05:56 UTC) #1
Ryan Hamilton
lgtm
5 years, 5 months ago (2015-07-17 23:06:27 UTC) #2
ramant (doing other things)
https://codereview.chromium.org/1237453008/diff/1/net/quic/quic_connection.cc File net/quic/quic_connection.cc (right): https://codereview.chromium.org/1237453008/diff/1/net/quic/quic_connection.cc#newcode738 net/quic/quic_connection.cc:738: QuicPacketSequenceNumber least_acked = GetLeastUnacked(); Hi Ryan and Ian, linux's ...
5 years, 5 months ago (2015-07-17 23:08:32 UTC) #3
Ryan Hamilton
5 years, 5 months ago (2015-07-17 23:21:33 UTC) #4
lgtm

https://codereview.chromium.org/1237453008/diff/1/net/quic/quic_connection.cc
File net/quic/quic_connection.cc (right):

https://codereview.chromium.org/1237453008/diff/1/net/quic/quic_connection.cc...
net/quic/quic_connection.cc:738: QuicPacketSequenceNumber least_acked =
GetLeastUnacked();
On 2015/07/17 23:08:31, ramant wrote:
> Hi Ryan and Ian,
>   linux's safe iterator doesn't allow accessing incoming_ack.missing_packets
if
> it is empty. Thus added the check for empty (will port that change back to
> internal source). 

Good point!

Powered by Google App Engine
This is Rietveld 408576698