Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1237453004: Reset sSpareSandboxedConnection when it gets unavailable (Closed)

Created:
5 years, 5 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 5 months ago
Reviewers:
Yaron, Maria
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset sSpareSandboxedConnection when it gets unavailable BUG=510662 Committed: https://crrev.com/d7f689a4e2159e5d1f2c2305067f8ea552fca696 Cr-Commit-Position: refs/heads/master@{#339578}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use equals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Jaekyun Seok (inactive)
yfriedman@ and mariakhomenko@, please review this CL.
5 years, 5 months ago (2015-07-16 01:37:30 UTC) #2
Yaron
also had a q on the bug https://codereview.chromium.org/1237453004/diff/1/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java File content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java (right): https://codereview.chromium.org/1237453004/diff/1/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java#newcode308 content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:308: if (connection ...
5 years, 5 months ago (2015-07-16 20:50:34 UTC) #3
Jaekyun Seok (inactive)
> also had a q on the bug I left the answer on the bug. ...
5 years, 5 months ago (2015-07-16 22:10:20 UTC) #4
Jaekyun Seok (inactive)
On 2015/07/16 22:10:20, Jaekyun Seok wrote: > > also had a q on the bug ...
5 years, 5 months ago (2015-07-20 22:52:24 UTC) #5
Maria
lgtm
5 years, 5 months ago (2015-07-20 23:27:27 UTC) #6
Yaron
lgtm as well
5 years, 5 months ago (2015-07-20 23:41:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237453004/20001
5 years, 5 months ago (2015-07-20 23:46:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 00:43:34 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 00:44:26 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7f689a4e2159e5d1f2c2305067f8ea552fca696
Cr-Commit-Position: refs/heads/master@{#339578}

Powered by Google App Engine
This is Rietveld 408576698