Issue 123743005: Update documentation of future.then/catchError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 123743005: Update documentation of future.then/catchError. (Closed)

Created:
6 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 11 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update documentation of future.then/catchError. Now mentions that throwing the same exception again is a rethrow. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=31533

Patch Set 2 : Address comments #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -29 lines)			Patch
	M	sdk/lib/async/future.dart	View	1	2 chunks	+49 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/123743005/diff/1/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/123743005/diff/1/sdk/lib/async/future.dart#newcode303 sdk/lib/async/future.dart:303: * The `onError` callback must have type `void ...

6 years, 11 months ago (2014-01-06 11:15:23 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #2 manually as r31533 (presubmit successful).

6 years, 11 months ago (2014-01-07 08:07:35 UTC) #3

Lasse Reichstein Nielsen

6 years, 11 months ago (2014-01-07 08:37:39 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/123743005/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/123743005/diff/1/sdk/lib/async/future.dart#ne...
sdk/lib/async/future.dart:303: * The `onError` callback must have type `void
onError(error)` or
Good catch!

Expand Messages | Collapse Messages

Issue 123743005: Update documentation of future.then/catchError. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments #

Messages