Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 123743004: Add v4l2capture to support webcam-based speed index in telemetry (Closed)

Created:
6 years, 11 months ago by szym
Modified:
6 years, 10 months ago
Reviewers:
open-source-third-party-reviews, darin (slow to review), security, jschuh, Daniel Berlin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add v4l2capture to support webcam-based speed index in telemetry v4l2capture is a python C extension to access Video4Linux camera devices. BUG=331450

Patch Set 1 #

Patch Set 2 : update .gitignore #

Patch Set 3 : update location of referencing module #

Patch Set 4 : add pauljensen to OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+561 lines, -0 lines) Patch
M .gitignore View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A third_party/v4l2capture/LICENSE View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/v4l2capture/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/v4l2capture/README.chromium View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/v4l2capture/setup.py View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/v4l2capture/v4l2capture.c View 1 chunk +505 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
szym
6 years, 11 months ago (2014-01-06 06:30:45 UTC) #1
Daniel Berlin
LGTM for open-source-third-party-reviews
6 years, 11 months ago (2014-01-06 08:32:13 UTC) #2
szym
security: ping
6 years, 11 months ago (2014-01-09 19:22:46 UTC) #3
szym
security: one more ping Note, this code will not ship with any product other than ...
6 years, 11 months ago (2014-01-23 01:53:17 UTC) #4
jschuh
If it's a profiling tool that doesn't ship with Chrome then you should be fine ...
6 years, 11 months ago (2014-01-23 05:02:20 UTC) #5
szym
On 2014/01/23 05:02:20, Justin Schuh wrote: > If it's a profiling tool that doesn't ship ...
6 years, 11 months ago (2014-01-23 07:44:37 UTC) #6
jschuh
On 2014/01/23 07:44:37, szym wrote: > On 2014/01/23 05:02:20, Justin Schuh wrote: > > If ...
6 years, 11 months ago (2014-01-23 17:18:21 UTC) #7
szym
darin@chromium.org: third_party OWNERS approval needed
6 years, 10 months ago (2014-01-31 17:39:47 UTC) #8
darin (slow to review)
LGTM
6 years, 10 months ago (2014-02-03 15:45:40 UTC) #9
szym
The CQ bit was checked by szym@chromium.org
6 years, 10 months ago (2014-02-03 16:22:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/123743004/150001
6 years, 10 months ago (2014-02-03 16:23:03 UTC) #11
commit-bot: I haz the power
Change committed as 248546
6 years, 10 months ago (2014-02-03 19:23:32 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:23:32 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 19:23:38 UTC) #14
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698