Issue 123743003: Re-enables docked windows by default in M34

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 123743003: Re-enables docked windows by default in M34 (Closed)

Created:
6 years, 11 months ago by varkha

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, sadrul, dcheng, ben+ash_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Re-enables docked windows by default in M34 (reverts issue 109663002) BUG=None TEST=Visual 1. in chrome://flags verify that ash-disable-docked-windows is present. 2. in chrome://flags verify that ash-enable-docked-windows is absent. 3. When running chrome without ash-enable-docked-windows it should be possible to dock a window at a screen edge. TEST=ash_unittests --gtest_filter=*Dock* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243178

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -39 lines)			Patch
M	ash/ash_switches.h	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	ash/ash_switches.cc	View	6 chunks	+17 lines, -17 lines	0 comments	Download
M	ash/wm/dock/docked_window_layout_manager_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/wm/dock/docked_window_resizer_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/wm/system_gesture_event_filter_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/wm/workspace_controller_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

varkha

sky@, this re-enables docked windows by default after M34 branch point. Please take a look ...

6 years, 11 months ago (2014-01-03 04:46:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/123743003/1

6 years, 11 months ago (2014-01-06 19:13:54 UTC) #3

Message was sent while issue was closed.

Change committed as 243178

Expand Messages | Collapse Messages