Implement complex super assignment.

sdk/lib/_internal/compiler/implementation/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   Selector getGetterSelectorInComplexSendSet(SendSet node);
@@ skipping 1987 matching lines @@
         return null;
       }
       if (currentClass.supertype == null) {
         // This is just to guard against internal errors, so no need
         // for a real error message.
         error(node.receiver, MessageKind.GENERIC,
               {'text': "Object has no superclass"});
       }
       // TODO(johnniwinther): Ensure correct behavior if currentClass is a
       // patch.
-      target = currentClass.lookupSuperMember(name);
+      target = currentClass.superclass.lookupSelector(

[kasperl, 2013/03/05 07:32:36]

I think this would be easier to read if you did something like:

   target = currentClass.lookupSuperMember(selector);

Manually going to the superclass everywhere seems a bit fishy.

[ngeoffray, 2013/03/05 08:46:25]

Done.

+          selector, superLookup: true);
       // [target] may be null which means invoking noSuchMethod on
       // super.
       if (target == null) {
         target = warnAndCreateErroneousElement(
             node, name, MessageKind.NO_SUCH_SUPER_MEMBER,
             {'className': currentClass, 'memberName': name});
         // We still need to register the invocation, because we might
         // call [:super.noSuchMethod:] that does a
         // [:InvocationMirror.invokeOn:].
         world.registerDynamicInvocation(selector.name, selector);
@@ skipping 266 matching lines @@
           getter = warnAndCreateErroneousElement(
               node.selector, field.name, MessageKind.CANNOT_RESOLVE_GETTER);
           compiler.backend.registerThrowNoSuchMethod();
         }
       } else if (target.impliesType()) {
         compiler.backend.registerThrowNoSuchMethod();
       } else if (target.modifiers.isFinal() || target.modifiers.isConst()) {
         setter = warnAndCreateErroneousElement(
             node.selector, target.name, MessageKind.CANNOT_RESOLVE_SETTER);
         compiler.backend.registerThrowNoSuchMethod();
-      } else if (isComplex && target.name == const SourceString('[]=')) {
-        getter = target.getEnclosingClass().lookupMember(
-            const SourceString('[]'));
-        if (getter == null) {
-          getter = warnAndCreateErroneousElement(
-              node, setter.name, MessageKind.CANNOT_RESOLVE_INDEX);
-          compiler.backend.registerThrowNoSuchMethod();
-        }
       }
     }
 
     visit(node.argumentsNode);
 
     // TODO(ngeoffray): Check if the target can be assigned.
     // TODO(ngeoffray): Warn if target is null and the send is
     // unqualified.
 
     Selector selector = mapping.getSelector(node);
     if (isComplex) {
       Selector getterSelector;
       if (selector.isSetter()) {
         getterSelector = new Selector.getterFrom(selector);
       } else {
         assert(selector.isIndexSet());
         getterSelector = new Selector.index();
       }
       registerSend(getterSelector, getter);
       mapping.setGetterSelectorInComplexSendSet(node, getterSelector);
+      if (node.isSuperCall) {
+        getter = currentClass.superclass.lookupSelector(
+            getterSelector, superLookup: true);
+        if (getter == null) {
+          target = warnAndCreateErroneousElement(
+              node, selector.name, MessageKind.NO_SUCH_SUPER_MEMBER,
+              {'className': currentClass, 'memberName': selector.name});
+          compiler.backend.registerSuperNoSuchMethod();
+        }
+      }
       useElement(node.selector, getter);
 
       // Make sure we include the + and - operators if we are using
       // the ++ and -- ones.  Also, if op= form is used, include op itself.
       void registerBinaryOperator(SourceString name) {
         Selector binop = new Selector.binaryOperator(name);
         world.registerDynamicInvocation(binop.name, binop);
         mapping.setOperatorSelectorInComplexSendSet(node, binop);
       }
       if (identical(source, '++')) {
@@ skipping 1474 matching lines @@
     return e;
   }
 
   /// Assumed to be called by [resolveRedirectingFactory].
   Element visitReturn(Return node) {
     Node expression = node.expression;
     return finishConstructorReference(visit(expression),
                                       expression, expression);
   }
 }