Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 12374087: Fix cast warnings on Win32 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7265 matching lines...) Expand 10 before | Expand all | Expand 10 after
7276 // Check for the hole and skip. 7276 // Check for the hole and skip.
7277 __ cmp(entity_name, masm->isolate()->factory()->the_hole_value()); 7277 __ cmp(entity_name, masm->isolate()->factory()->the_hole_value());
7278 __ j(equal, &good, Label::kNear); 7278 __ j(equal, &good, Label::kNear);
7279 7279
7280 // Check if the entry name is not a unique name. 7280 // Check if the entry name is not a unique name.
7281 __ mov(entity_name, FieldOperand(entity_name, HeapObject::kMapOffset)); 7281 __ mov(entity_name, FieldOperand(entity_name, HeapObject::kMapOffset));
7282 __ test_b(FieldOperand(entity_name, Map::kInstanceTypeOffset), 7282 __ test_b(FieldOperand(entity_name, Map::kInstanceTypeOffset),
7283 kIsInternalizedMask); 7283 kIsInternalizedMask);
7284 __ j(not_zero, &good); 7284 __ j(not_zero, &good);
7285 __ cmpb(FieldOperand(entity_name, Map::kInstanceTypeOffset), 7285 __ cmpb(FieldOperand(entity_name, Map::kInstanceTypeOffset),
7286 static_cast<int8_t>(SYMBOL_TYPE)); 7286 static_cast<uint8_t>(SYMBOL_TYPE));
7287 __ j(not_equal, miss); 7287 __ j(not_equal, miss);
7288 __ bind(&good); 7288 __ bind(&good);
7289 } 7289 }
7290 7290
7291 NameDictionaryLookupStub stub(properties, r0, r0, NEGATIVE_LOOKUP); 7291 NameDictionaryLookupStub stub(properties, r0, r0, NEGATIVE_LOOKUP);
7292 __ push(Immediate(Handle<Object>(name))); 7292 __ push(Immediate(Handle<Object>(name)));
7293 __ push(Immediate(name->Hash())); 7293 __ push(Immediate(name->Hash()));
7294 __ CallStub(&stub); 7294 __ CallStub(&stub);
7295 __ test(r0, r0); 7295 __ test(r0, r0);
7296 __ j(not_zero, miss); 7296 __ j(not_zero, miss);
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
7416 // lookup we have to bailout as this key might be equal to the 7416 // lookup we have to bailout as this key might be equal to the
7417 // key we are looking for. 7417 // key we are looking for.
7418 7418
7419 // Check if the entry name is not a unique name. 7419 // Check if the entry name is not a unique name.
7420 Label cont; 7420 Label cont;
7421 __ mov(scratch, FieldOperand(scratch, HeapObject::kMapOffset)); 7421 __ mov(scratch, FieldOperand(scratch, HeapObject::kMapOffset));
7422 __ test_b(FieldOperand(scratch, Map::kInstanceTypeOffset), 7422 __ test_b(FieldOperand(scratch, Map::kInstanceTypeOffset),
7423 kIsInternalizedMask); 7423 kIsInternalizedMask);
7424 __ j(not_zero, &cont); 7424 __ j(not_zero, &cont);
7425 __ cmpb(FieldOperand(scratch, Map::kInstanceTypeOffset), 7425 __ cmpb(FieldOperand(scratch, Map::kInstanceTypeOffset),
7426 static_cast<int8_t>(SYMBOL_TYPE)); 7426 static_cast<uint8_t>(SYMBOL_TYPE));
7427 __ j(not_equal, &maybe_in_dictionary); 7427 __ j(not_equal, &maybe_in_dictionary);
7428 __ bind(&cont); 7428 __ bind(&cont);
7429 } 7429 }
7430 } 7430 }
7431 7431
7432 __ bind(&maybe_in_dictionary); 7432 __ bind(&maybe_in_dictionary);
7433 // If we are doing negative lookup then probing failure should be 7433 // If we are doing negative lookup then probing failure should be
7434 // treated as a lookup success. For positive lookup probing failure 7434 // treated as a lookup success. For positive lookup probing failure
7435 // should be treated as lookup failure. 7435 // should be treated as lookup failure.
7436 if (mode_ == POSITIVE_LOOKUP) { 7436 if (mode_ == POSITIVE_LOOKUP) {
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
7873 // Restore ecx. 7873 // Restore ecx.
7874 __ pop(ecx); 7874 __ pop(ecx);
7875 __ ret(0); 7875 __ ret(0);
7876 } 7876 }
7877 7877
7878 #undef __ 7878 #undef __
7879 7879
7880 } } // namespace v8::internal 7880 } } // namespace v8::internal
7881 7881
7882 #endif // V8_TARGET_ARCH_IA32 7882 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698