Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 12374074: MIPS: Renamed "symbols" to "internalized strings" throughout the code base, in preparation of the i… (Closed)

Created:
7 years, 9 months ago by palfia
Modified:
7 years, 9 months ago
Reviewers:
kisg, Paul Lind, danno, rossberg
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Renamed "symbols" to "internalized strings" throughout the code base, in preparation of the introduction of ES6 'symbols' (aka private/unique names). Port r13781 (59f39a06) Original commit message: The SymbolTable became the StringTable. I also made sure to adapt all comments. The only remaining use of the term "symbol" (other than unrelated uses in the parser and such) is now 'NewSymbol' in the API and the 'V8.KeyedLoadGenericSymbol' counter, changing which might break embedders. The one functional change in this CL is that I removed the former 'empty_string' constant, since it is redundant given the 'empty_symbol' constant that we also had (and both were used inconsistently). BUG= Committed: https://code.google.com/p/v8/source/detail?r=13807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -102 lines) Patch
M src/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 22 chunks +58 lines, -54 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M src/mips/ic-mips.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 9 months ago (2013-03-04 04:14:39 UTC) #1
rossberg
LGTM
7 years, 9 months ago (2013-03-04 14:03:34 UTC) #2
palfia
7 years, 9 months ago (2013-03-04 14:45:49 UTC) #3
Message was sent while issue was closed.
Committed manually as r13807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698