src/atomicops.h - Issue 12374065: fix x32 handling of Atomic64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/atomicops.h

Issue 12374065: fix x32 handling of Atomic64 (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/atomicops.h

===================================================================

--- src/atomicops.h (revision 13791)

+++ src/atomicops.h (working copy)

@@ -58,7 +58,7 @@

#ifdef V8_HOST_ARCH_64_BIT

// We need to be able to go between Atomic64 and AtomicWord implicitly. This

// means Atomic64 and AtomicWord should be the same type on 64-bit.

-#if defined(__APPLE__)

+#if defined(__ILP32__) || defined(__APPLE__)

Brad Chen (chromium) 2013/03/04 23:27:32 So, actually trying this in my own build, I'm not

// MacOS is an exception to the implicit conversion rule above,

// because it uses long for intptr_t.

typedef int64_t Atomic64;

« no previous file with comments | « no previous file | no next file » | no next file with comments »