Bluetooth: Send UI notifications when the connecting status changes.

device/bluetooth/bluetooth_device_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_device_chromeos.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 130 matching lines @@
   return !confirmation_callback_.is_null();
 }
 
 void BluetoothDeviceChromeOS::Connect(
     PairingDelegate* pairing_delegate,
     const base::Closure& callback,
     const ConnectErrorCallback& error_callback) {
   // This is safe because Connect() and its callbacks are called in the same
   // thread.
   connecting_calls_++;
+  if (!connecting_) {
+    connecting_ = true;
+    adapter_->NotifyDeviceChanged(this);
+  }
   connecting_ = !!connecting_calls_;
   // Set the decrement to be issued when either callback is called.
   base::Closure wrapped_callback = base::Bind(
       &BluetoothDeviceChromeOS::OnConnectCallbackCalled,
       weak_ptr_factory_.GetWeakPtr(),
       callback);
   ConnectErrorCallback wrapped_error_callback = base::Bind(
       &BluetoothDeviceChromeOS::OnConnectErrorCallbackCalled,
       weak_ptr_factory_.GetWeakPtr(),
       error_callback);
@@ skipping 356 matching lines @@
   if (service_records_loaded_) {
     callback.Run(service_records_);
   } else {
     error_callback.Run();
   }
 }
 
 void BluetoothDeviceChromeOS::OnConnectCallbackCalled(
     const base::Closure& callback) {
   // Update the connecting status.
+  bool prev_connecting = !!connecting_calls_;

[keybuk, 2013/04/18 15:54:17]

why is this not just:

  bool prev_connecting = connecting_;

?

[deymo, 2013/04/18 16:27:43]

It could be any of those... why one or the other?? Looks the same for me.

[keybuk, 2013/04/18 17:12:05]

You're making an assumption that connecting_ is calculated from
connecting_calls_ - someone may change that in the future and unwittingly break
this code

prev_connecting = connecting_
OR
prev_connecting_calls_ = connecting_calls_

would be both fine

[deymo, 2013/04/19 01:40:30]

Done.

   connecting_calls_--;
   connecting_ = !!connecting_calls_;
   callback.Run();
+  if (prev_connecting != connecting_) adapter_->NotifyDeviceChanged(this);
 }
 
 void BluetoothDeviceChromeOS::OnConnectErrorCallbackCalled(
     const ConnectErrorCallback& error_callback,
     enum ConnectErrorCode error_code) {
   // Update the connecting status.
+  bool prev_connecting = !!connecting_calls_;

[keybuk, 2013/04/18 15:54:17]

ditto

[deymo, 2013/04/19 01:40:30]

Done.

   connecting_calls_--;
   connecting_ = !!connecting_calls_;
   error_callback.Run(error_code);
+  if (prev_connecting != connecting_) adapter_->NotifyDeviceChanged(this);
 }
 
 void BluetoothDeviceChromeOS::ConnectApplications(
     const base::Closure& callback,
     const ConnectErrorCallback& error_callback) {
   // Introspect the device object to determine supported applications.
   DBusThreadManager::Get()->GetIntrospectableClient()->
       Introspect(bluetooth_device::kBluetoothDeviceServiceName,
                  object_path_,
                  base::Bind(&BluetoothDeviceChromeOS::OnIntrospect,
@@ skipping 301 matching lines @@
 }
 
 
 // static
 BluetoothDeviceChromeOS* BluetoothDeviceChromeOS::Create(
     BluetoothAdapterChromeOS* adapter) {
   return new BluetoothDeviceChromeOS(adapter);
 }
 
 }  // namespace chromeos