Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8135)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_ui.h

Issue 12374007: signin: force web signin flow initiated visits to accounts.google.com to their own process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: charlie's review Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_ui.h
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.h b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.h
index decb4024d08959b7652dc035ca877e5396ae05d3..232107da3be5531f7d8c849e4a6eab4913e982fb 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.h
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.h
@@ -28,6 +28,13 @@ class SyncPromoUI : public content::WebUIController {
// Constructs a SyncPromoUI.
explicit SyncPromoUI(content::WebUI* web_ui);
+ // This is used to distinguish URLs belonging to the special web signin flow
+ // running in the special signin process from other URLs on the same domain.
+ // We do not grant WebUI privilieges / bindings to this process or to URLs of
+ // this scheme; enforcement of privileges is handled separately by
+ // OneClickSigninHelper.
+ static const char* kChromeSigninEffectiveOrigin;
Charlie Reis 2013/03/06 01:28:46 nit: kChromeSigninEffectiveSite (Site is more acc
+
// Returns true if the sync promo should be visible.
// |profile| is the profile of the tab the promo would be shown on.
static bool ShouldShowSyncPromo(Profile* profile);
@@ -79,6 +86,10 @@ class SyncPromoUI : public content::WebUIController {
// Forces UseWebBasedSigninFlow() to return true when set; used in tests only.
static void ForceWebBasedSigninFlowForTesting(bool force);
+ // Returns true if |url| is a web signin URL and should be hosted in an
+ // isolated, privileged signin process.
+ static bool IsWebBasedSigninFlowURL(const GURL& url);
+
private:
DISALLOW_COPY_AND_ASSIGN(SyncPromoUI);
};

Powered by Google App Engine
This is Rietveld 408576698