chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 12374007: signin: force web signin flow initiated visits to accounts.google.com to their own process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 12374007: signin: force web signin flow initiated visits to accounts.google.com to their own process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use extension-based scheme instead. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/signin/signin_manager_unittest.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper_unittest.cc » ('j') | chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index f0b8cedcfaa28bea1706fd0a45be47f6f23522ab..c119957ee7b8baf7f5897e78f78a63a4d75510fa 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -55,6 +55,7 @@

#include "chrome/common/url_constants.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/page_navigator.h"

+#include "content/public/browser/render_process_host.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_view.h"

#include "content/public/common/frame_navigate_params.h"

@@ -553,6 +554,14 @@ bool OneClickSigninHelper::CanOffer(content::WebContents* web_contents,

if (!manager)

return false;

+ if (!manager->IsSigninProcess(

+ web_contents->GetRenderProcessHost()->GetID())) {

+ // We only allow the dedicated signin process to sign the user into

+ // Chrome without intervention, because it doesn't load any untrusted

+ // pages.

+ return false;

+ }

// If the signin manager already has an authenticated name, then this is a

// re-auth scenario. Make sure the email just signed in corresponds to the

// the one sign in manager expects.