signin: force web signin flow initiated visits to accounts.google.com to their own process.

chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
@@ skipping 78 matching lines @@
   html_source->AddLocalizedStrings(localized_strings);
   html_source->SetJsonPath(kStringsJsFile);
   html_source->AddResourcePath(kSyncPromoJsFile, IDR_SYNC_PROMO_JS);
   html_source->SetDefaultResource(IDR_SYNC_PROMO_HTML);
   html_source->SetUseJsonJSFormatV2();
   return html_source;
 }
 
 }  // namespace
 
+// Under the covers, we use a dummy chrome-extension to serve the purposes

[Charlie Reis, 2013/03/06 00:14:54]

nit: chrome-extension URL
(We don't have an actual extension object for it, which is what it sounds like
in the comment.)

[tim (not reviewing), 2013/03/06 01:04:08]

Done.

+// outlined in the .h file comment for this string.
+const char* SyncPromoUI::kChromeSigninEffectiveURL =
+    "chrome-extension://acfccoigjajmmgbhpfbjnpckhjjegnih";
+
 SyncPromoUI::SyncPromoUI(content::WebUI* web_ui) : WebUIController(web_ui) {
   SyncPromoHandler* handler = new SyncPromoHandler(
       g_browser_process->profile_manager());
   web_ui->AddMessageHandler(handler);
 
   // Set up the chrome://theme/ source.
   Profile* profile = Profile::FromWebUI(web_ui);
   ThemeSource* theme = new ThemeSource(profile);
   content::URLDataSource::Add(profile, theme);
 
@@ skipping 143 matching lines @@
       base::StringAppendF(&url_string, "&%s=%s", kSyncPromoQueryKeyNextPage,
                           net::EscapeQueryParamValue(next_page.spec(),
                                                      false).c_str());
     }
   }
 
   return GURL(url_string);
 }
 
 // static
+bool SyncPromoUI::IsWebBasedSigninFlowURL(const GURL& url) {
+  if (url == GURL(kChromeSigninEffectiveURL))

[Charlie Reis, 2013/03/06 00:14:54]

You should check the scheme and host.

[tim (not reviewing), 2013/03/06 01:04:08]

Done.

+    return true;
+
+  GURL service_login(GaiaUrls::GetInstance()->service_login_url());
+  if (url.GetOrigin() != service_login.GetOrigin())
+    return false;
+
+  return url.path() == service_login.path();
+}
+
+// static
 GURL SyncPromoUI::GetNextPageURLForSyncPromoURL(const GURL& url) {
   const char* key_name = UseWebBasedSigninFlow() ? kSyncPromoQueryKeyContinue :
       kSyncPromoQueryKeyNextPage;
   std::string value;
   if (net::GetValueForKeyInQuery(url, key_name, &value)) {
     return GURL(value);
   }
   return GURL();
 }
 
@@ skipping 29 matching lines @@
       g_force_web_based_signin_flow;
 #else
   return false;
 #endif
 }
 
 // static
 void SyncPromoUI::ForceWebBasedSigninFlowForTesting(bool force) {
   g_force_web_based_signin_flow = force;
 }